Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 73318 - module-init-tools fails on a reiser4 / partition
Summary: module-init-tools fails on a reiser4 / partition
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High major
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-04 02:49 UTC by Ginsu
Modified: 2005-08-14 06:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Check if it is a directory with stat(2) prior to opendir(3). (module-init-tools-3.1-fix_file_as_dir.patch,628 bytes, patch)
2004-12-04 02:50 UTC, Ginsu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ginsu 2004-12-04 02:49:10 UTC
When module-init-tools parses it's config files, it checks to see if it is a directory with opendir and if it fails it reads it as a file.  In reiser4 files are directories so opendir always passes but there are no contents so it never reads it as a file.   Attached is a patch to first run stat(2) to check if it really is a directory.

Reproducible: Always
Steps to Reproduce:
1. Use reiser4 for your / partition.
2. run modprobe -c
Actual Results:  
modprobe -c will return nothing even though /etc/modprobe.conf contains
configuration data.
Comment 1 Ginsu 2004-12-04 02:50:37 UTC
Created attachment 45252 [details, diff]
Check if it is a directory with stat(2) prior to opendir(3).
Comment 2 SpanKY gentoo-dev 2005-05-20 22:53:35 UTC
e-mailed patch upstream
Comment 3 Rusty Russell 2005-05-22 18:46:47 UTC
That is horrible... it if has data and no children Reiser4 should return ENOTDIR.

The correct behaviour on such a filesystem is to read *and* recurse, which is
what I have implemented in 3.2-pre6, which I'm testing now and will soon upload.
 Please get back to me if it's not working.

Cheers,
Rusty.
Comment 4 SpanKY gentoo-dev 2005-08-14 06:15:45 UTC
3.2_pre7 is in portage now which should have this resolved properly