Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732744 - www-client/netsurf and dependency ebuilds source gentoo-helpers.sh
Summary: www-client/netsurf and dependency ebuilds source gentoo-helpers.sh
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Philipp Ammann
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-15 14:11 UTC by Michael Orlitzky
Modified: 2020-08-15 12:10 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2020-07-15 14:11:45 UTC
Netsurf and all of its dependencies run,

  source /usr/share/netsurf-buildsystem/gentoo-helpers.sh

at build time. (That file is installed by dev-util/netsurf-buildsystem). This is a violation of

  https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0102

which says

  The ebuild code must be fully contained within .ebuild and .eclass files.
  It is forbidden to load additional ebuild code from other files via source, 
  eval or any other possible method.

The code from that file should be moved into an eclass.
Comment 1 Michael Orlitzky gentoo-dev 2020-08-15 12:10:55 UTC
Fixed after a major effort by Lukas Vacek. Thanks!