732004 – PORTAGE_IONICE_COMMAND is run with invalid arguments if package atom invalid, producing error

Bug 732004 - PORTAGE_IONICE_COMMAND is run with invalid arguments if package atom invalid, producing error

Summary: PORTAGE_IONICE_COMMAND is run with invalid arguments if package atom invalid,...

Status:	UNCONFIRMED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core - Configuration (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2020-07-09 23:06 UTC by R030t1
Modified:	2020-07-10 01:14 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description R030t1 2020-07-09 23:06:21 UTC

If the package/set doesn't exist:

	# emerge -uDNa @invalid
	FEATURES variable contains unknown value(s): split-logs
	ionice: option requires an argument -- 'p'
	Try 'ionice --help' for more information.
	 * PORTAGE_IONICE_COMMAND returned 1
	 * See the make.conf(5) man page for PORTAGE_IONICE_COMMAND usage instructions.
	emerge: There are no sets to satisfy 'invalid'. The following sets exist:


	PORTAGE_IONICE_COMMAND="ionice -c 3 -p \${PID}"

Comment 1 Zac Medico gentoo-dev

2020-07-10 01:14:07 UTC

I'm not able to reproduce that, and the relevant code should not be affected by arguments. The PID value should be valid in any case since it's obtained from os.getpid(). The symptom suggests that either the shlex_split or varexpand function has misbehaved, but I have no explanation for how that could happen.

https://gitweb.gentoo.org/proj/portage.git/tree/lib/_emerge/actions.py?h=portage-2.3.103#n2638