Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 73186 - Mistake in subversion-1.1.1-r3 ebuild pkg_config
Summary: Mistake in subversion-1.1.1-r3 ebuild pkg_config
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Paul de Vrieze (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-02 20:19 UTC by John Croisant
Modified: 2004-12-03 02:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Croisant 2004-12-02 20:19:12 UTC
Line 334 in dev-utils/subversion/subversion-1.1.1-r3.ebuild currently reads:

if [[ -f ${SVN_REPOS_LOC}/repos ]]; then

It should read:

if [[ -d ${SVN_REPOS_LOC}/repos ]]; then

The code is intended to check if a subversion repository exists, and if so, issues a warning message and quits. Otherwise, it creates the repository. "${SVN_REPOS_LOC}/repos" is a directory, so -f is the wrong flag to use to check for it.

This bug doesn't hurt anything, because svnadmin won't overwrite the repository anyway. Just a minor annoyance, and a very quick fix.

Reproducible: Always
Steps to Reproduce:
Comment 1 Paul de Vrieze (RETIRED) gentoo-dev 2004-12-03 02:03:57 UTC
It should actually be " -e " as the existence of either a file or a directory should cause it to refuse. Anyway, I've fixed it. Thanks.