Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 7301 - libdv gtk dependency
Summary: libdv gtk dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: Lowest normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-31 10:34 UTC by Markus Bertheau (RETIRED)
Modified: 2003-08-25 19:53 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Configure patch to turn of gtk for compilation of lib and testprograms (configure.diff,2.59 KB, patch)
2003-05-06 08:44 UTC, Christian Jiresjö
Details | Diff
Configure patch to turn of gtk for compilation of lib and testprograms (configure.diff,2.59 KB, patch)
2003-05-06 08:44 UTC, Christian Jiresjö
Details | Diff
Makefile.in companion for configure patch (Makefile.in.diff,363 bytes, patch)
2003-05-06 08:47 UTC, Christian Jiresjö
Details | Diff
Modified ebuild (libdv-0.98.ebuild,1.19 KB, text/plain)
2003-05-06 08:48 UTC, Christian Jiresjö
Details
Makefile diff for libdv-0.99 (Makefile.in.diff,392 bytes, patch)
2003-05-13 08:47 UTC, Christian Jiresjö
Details | Diff
configure diff for libdv-0.99 (configure.diff,2.56 KB, patch)
2003-05-13 08:48 UTC, Christian Jiresjö
Details | Diff
diff to libdv-0.99 ebuild to fix gtkless compiling (libdv-0.99.ebuild.diff,648 bytes, patch)
2003-05-13 08:50 UTC, Christian Jiresjö
Details | Diff
configure.ac autoconf patch (not directly needed for gentoo) (configure.ac.diff,938 bytes, patch)
2003-05-13 10:02 UTC, Christian Jiresjö
Details | Diff
fixed configure.diff for libdv-0.99 (configure.diff,2.51 KB, patch)
2003-05-20 06:06 UTC, Christian Jiresjö
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Bertheau (RETIRED) gentoo-dev 2002-08-31 10:34:43 UTC
checking for pkg-config... /usr/bin/pkg-config
checking for glib >= 1.2.4 gtk+ >= 1.2.4... sh: gtk-config: command not found
sh: gtk-config: command not found
sh: gtk-config: command not found
sh: gtk-config: command not found
sh: gtk-config: command not found
sh: gtk-config: command not found
Requested 'gtk+ >= 1.2.4' but version of GTK+ is 

configure: error: Library requirements (glib >= 1.2.4 gtk+ >= 1.2.4) not met;
consider adjusting the PKG_CONFIG_PATH environment variable if your libraries
are in a nonstandard prefix so pkg-config can find them.

!!! ERROR: The ebuild did not complete successfully.
!!! Function econf, Line 9, Exitcode 1
!!! econf failed

amethyst root # 

I shouldn't be as easy as to add gtk+-1.2 as a dependency, have a look at bug
7000 for reference.
Comment 1 Markus Bertheau (RETIRED) gentoo-dev 2002-08-31 10:39:39 UTC
I have -gtk in my USE and no gtk+ version is installed.
Comment 2 Spider (RETIRED) gentoo-dev 2002-09-15 05:45:04 UTC
which version of libdv?
Comment 3 Markus Bertheau (RETIRED) gentoo-dev 2002-09-15 06:11:58 UTC
libdv-0.98
Comment 4 Markus Bertheau (RETIRED) gentoo-dev 2002-09-15 08:54:30 UTC
The Problem is the following:

libdvs configure.ac checks for gtk even if --disable-gtk was passed. When I
patch configure.ac with that patch:

--- libdv-0.98/configure.ac	Tue Jul 30 18:36:49 2002
+++ libdv-0.98-patched/configure.ac	Sun Sep 15 15:32:09 2002
@@ -150,10 +150,12 @@
 
 dnl Checks for libraries.
 
-REQUIRES='glib >= 1.2.4 gtk+ >= 1.2.4'
-PKG_CHECK_MODULES(GTK,$REQUIRES)
-dnl Libs above are required for the apps, but not for the lib itself.
-REQUIRES=''
+if $use_gtk; then
+	REQUIRES='glib >= 1.2.4 gtk+ >= 1.2.4'
+	PKG_CHECK_MODULES(GTK,$REQUIRES)
+	dnl Libs above are required for the apps, but not for the lib itself.
+	REQUIRES=''
+fi
 
 dnl pass-thru to .pc files
 AC_SUBST(REQUIRES)

, a compile with gtk in USE succeeds, without gtk, it fails:

checking for XvQueryAdaptors in -lXv... no
configure: error: Could not find Xv Lib

!!! ERROR: The ebuild did not complete successfully.

I have no idea.

The following patch, unrelated, can be applied to the ebuild:

--- libdv-0.98-r1.ebuild	Sun Sep 15 15:51:41 2002
+++ /usr/portage/media-libs/libdv/libdv-0.98.ebuild	Wed Aug 14 15:20:44 2002
@@ -15,11 +15,9 @@
 DEPEND=" dev-libs/popt
 	gtk? ( =x11-libs/gtk+-1.2* )
 	gtk? ( =dev-libs/glib-1.2* )
-	x11-base/xfree
+	xv? ( x11-base/xfree )
 	dev-util/pkgconfig
 	sdl? ( >=media-libs/libsdl-1.2.4.20020601 )"
-#	If we comment out the conditional xv-disabling below, make that dep
non-optional, too
-#	xv? ( x11-base/xfree )
 	
 src_compile() {

Comment 5 foser (RETIRED) gentoo-dev 2002-10-14 18:08:51 UTC
Can you maybe make a working patch ? I doubt the config.ac file is actually used
.. I would appreciate it, i won't have time to have a good look at this myself
for some time and it's not really a gtk issue, more like a broken config script.
Comment 6 foser (RETIRED) gentoo-dev 2003-01-11 11:24:05 UTC
reopening
Comment 7 foser (RETIRED) gentoo-dev 2003-01-11 11:25:30 UTC
Your bug, you can fix it or close it or whatever you like ;)

I don't think the gnome team will get around to it any time soon (or any time
ever to be more realistic :/).
Comment 8 Martin Holzer (RETIRED) gentoo-dev 2003-01-22 12:33:44 UTC
is this still an issue ?
Comment 9 Jim Marshall 2003-01-24 15:19:57 UTC
It seems to be. I just now emerge rsynced, then tried to emerge libdv with -
gtk in USE, and no gtk installed. I got errors exactly as in the original bug 
report.
Comment 10 den_RDC 2003-03-06 19:34:30 UTC
I can confirm Jim Marshall, this is still an issue. 
I encountered this while trying to emerge mplayer, and after checking the mplayer ebuild i constated that if you want mplayer with mencoder (encode use flag), it needs libdv (wich is not very logical to me, afaik mencoder works perfect without libdv).
I never intend to use the DV format, so this is a bit annoying.
Comment 12 Stephane Grenier 2003-04-23 13:39:37 UTC
I have the same problem, i have USE="-gtk" (i dont have GTK+ 1.2 installed) and emerging libdv fails.
Comment 13 Christian Jiresjö 2003-05-06 08:44:21 UTC
Created attachment 11563 [details, diff]
Configure patch to turn of gtk for compilation of lib and testprograms

This patch improves the handling of --disable-gtk and --disable-gtktest (make
them actually work) so you can compile libdv without gtk.
Comment 14 Christian Jiresjö 2003-05-06 08:44:56 UTC
Created attachment 11564 [details, diff]
Configure patch to turn of gtk for compilation of lib and testprograms

This patch improves the handling of --disable-gtk and --disable-gtktest (make
them actually work) so you can compile libdv without gtk.
Comment 15 Christian Jiresjö 2003-05-06 08:47:25 UTC
Created attachment 11565 [details, diff]
Makefile.in companion for configure patch

Needed by the configure patch to disable gtktest software compile
Comment 16 Christian Jiresjö 2003-05-06 08:48:57 UTC
Created attachment 11566 [details]
Modified ebuild

Modified ebuild to also disable gtk test software. (Warning enables xv-config)
Comment 17 Markus Bertheau (RETIRED) gentoo-dev 2003-05-06 12:23:06 UTC
Thanks very much for this patch, I'll try to get it in soon. Have you tried to get them upstream, i.e. to the libdv devs?
Comment 18 Radek Podgorny 2003-05-11 14:00:06 UTC
Please, please, please...

Can you pass it to the main portage tree as soon as possible, please? My whole cluster is useless until then... :-(

Radek Podgorny
Comment 19 Christian Jiresjö 2003-05-13 08:47:56 UTC
Created attachment 11885 [details, diff]
Makefile diff for libdv-0.99
Comment 20 Christian Jiresjö 2003-05-13 08:48:24 UTC
Created attachment 11886 [details, diff]
configure diff for libdv-0.99
Comment 21 Christian Jiresjö 2003-05-13 08:50:21 UTC
Created attachment 11888 [details, diff]
diff to libdv-0.99 ebuild to fix gtkless compiling
Comment 22 Christian Jiresjö 2003-05-13 08:51:40 UTC
Comment on attachment 11886 [details, diff]
configure diff for libdv-0.99

will try to create an autoconf/automake-patch as well and push it to libdv
developers
Comment 23 Christian Jiresjö 2003-05-13 10:02:41 UTC
Created attachment 11900 [details, diff]
configure.ac autoconf patch (not directly needed for gentoo)

I will try to push this patch for configure.ac to libdv-developers to fix this
problem once and for all.
Comment 24 Markus Bertheau (RETIRED) gentoo-dev 2003-05-13 15:20:17 UTC
Hmm, your configure patch doesn't quite work here:

amethyst libdv # USE="-gtk -sdl -xv" emerge libdv
Calculating dependencies ...done!
>>> emerge (1 of 1) media-libs/libdv-0.99-r1 to /
>>> md5 ;-) libdv-0.99.tar.gz
>>> Unpacking source...
>>> Unpacking libdv-0.99.tar.gz to /var/tmp/portage/libdv-0.99-r1/work
patching file Makefile.in
patching file configure
Reversed (or previously applied) patch detected!  Assume -R? [n] y
>>> Source unpacked.
configure: WARNING: If you wanted to set the --build type, don't use --host.
    If a cross compiler is detected then cross compile mode will be used.
checking build system type... i686-pc-linux-gnu
checking host system type... i586-pc-linux-gnu
checking target system type... i586-pc-linux-gnu
[...]
checking for pkg-config... /usr/bin/pkg-config
checking for glib >= 1.2.4 gtk+ >= 1.2.4... sh: line 1: gtk-config: command not 
found
sh: line 1: gtk-config: command not found
sh: line 1: gtk-config: command not found
sh: line 1: gtk-config: command not found
sh: line 1: gtk-config: command not found
sh: line 1: gtk-config: command not found
Requested 'gtk+ >= 1.2.4' but version of GTK+ is 

configure: error: Library requirements (glib >= 1.2.4 gtk+ >= 1.2.4) not met; co
nsider adjusting the PKG_CONFIG_PATH environment variable if your libraries are 
in a nonstandard prefix so pkg-config can find them.

!!! ERROR: media-libs/libdv-0.99-r1 failed.
Comment 25 Christian Jiresjö 2003-05-20 06:06:06 UTC
Created attachment 12188 [details, diff]
fixed configure.diff for libdv-0.99

There is a bug in libdv-0.99.ebuild
xv-line contains cong instead of conf
Comment 26 christoph wegener 2003-05-31 06:38:31 UTC
Thanks!

I applied the patches from
attachement 11885
attachement 11888
attachement 12188

and libdv-0.99 compiled fine for me without requiring gtk+-1.2.

Comment 27 Adrian Gygax 2003-07-18 04:44:29 UTC
Just want to remind that this bug is still an issue!

This bug makes it hard to keep the box GTK 1 free. libdv ist depended on by many packages!
Comment 28 Martin Holzer (RETIRED) gentoo-dev 2003-07-18 05:03:15 UTC
gtk guru :)
Comment 29 foser (RETIRED) gentoo-dev 2003-08-18 04:06:16 UTC
not this one again 
Comment 30 Alastair Tse (RETIRED) gentoo-dev 2003-08-20 00:36:20 UTC
thanks to christian for the patches. i've put in a libdv-0.99-r1 with gtk+ disabling working.

i note that max@gentoo.org had just removed the gtk useflag from libdv-0.99.
Comment 31 Michael N. Mikhulya 2003-08-25 03:30:40 UTC
I don't know is it a sequence from this bug, or a new bug.
But there is next problem with libdv-0.99-r1:
if I try to ACCEPT_KEYWORDS=~x86 USE="-gtk" emerge libdv
then error occurs on 'configure' stage:
"""
checking for XvQueryAdaptors in -lXv... no
configure: error: Could not find Xv Lib
 
!!! ERROR: media-libs/libdv-0.99-r1 failed.
!!! Function econf, Line 320, Exitcode 1
!!! econf failed
"""

But if I try ACCEPT_KEYWORDS=~x86 USE="gtk" emerge libdv
then configure stage accomplishes successfully. (xv-3.10a-r3 is installed)
"""
checking for gtk-config... /usr/bin/gtk-config
checking for GTK - version >= 1.2.4... yes
checking for XvQueryAdaptors in -lXv... yes
"""

If this another bug, please open new bug, elsewhere reopen this bug.
Comment 32 Michael N. Mikhulya 2003-08-25 19:53:55 UTC
with last patch all works fine
thanks for great job!