Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 726718 - kde-plasma/kwin-5.18.5-r1 - .../work/kwin-5.18.5/colorcorrection/clockskewnotifierengine_linux.cpp:38:77: error: use of undeclared identifier 'errno'
Summary: kde-plasma/kwin-5.18.5-r1 - .../work/kwin-5.18.5/colorcorrection/clockskewnot...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks: systemwide-clang
  Show dependency tree
 
Reported: 2020-06-02 02:18 UTC by unhappy-ending
Modified: 2020-08-21 10:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fix undeclared identifier in kwin-5.18+ (kwin-18.0-clockskewnotifierengine_linux.patch,470 bytes, patch)
2020-06-02 02:18 UTC, unhappy-ending
Details | Diff
pre-patch failure and post-patch success build logs (kde-plasma.zip,120.67 KB, application/zip)
2020-06-02 02:26 UTC, unhappy-ending
Details

Note You need to log in before you can comment on or make changes to this bug.
Description unhappy-ending 2020-06-02 02:18:41 UTC
Created attachment 643098 [details, diff]
fix undeclared identifier in kwin-5.18+

My system is mostly compiled using clang, the clang runtime compiler-rt, llvm's libc++ and the llvm toolchain. I haven't tested this using gcc so I don't know if gcc catches the same error. kwin will fail the compile phase when trying to compile clockskewnotifierengine_linux.cpp which is new from the kwin-5.17 to kwin-5.18 brach. The issue is an undeclared identifier. I'm attaching a patch which declares the identifier so kwin can compile proper under clang + the llvm toolchain.
Comment 1 unhappy-ending 2020-06-02 02:23:28 UTC
emerge --info
Portage 2.3.100 (python 3.7.7-final-0, default/linux/amd64/17.1, gcc-10.1.0, glibc-2.31-r3, 5.6.0-pf7 x86_64)
=================================================================
System uname: Linux-5.6.0-pf7-x86_64-AMD_Ryzen_7_1700_Eight-Core_Processor-with-gentoo-2.7
KiB Mem:    16342400 total,  10794864 free
KiB Swap:          0 total,         0 free
Head commit of repository gentoo: 603bf911386102b1bce2a62b6c207cd708e51159

Head commit of repository audio-overlay: f750fd89a4c673d0078c5fe6e0207c7298f7eaf0

Head commit of repository brave-overlay: 1a4fd9cc42504992a6cbdc981a59190bbedb68c3

Timestamp of repository calculate: Mon, 01 Jun 2020 11:35:02 +0000
Head commit of repository calculate: 3d1d3e17945a63c87ce1105aeb4f61620a1430f5

Head commit of repository cg: 337e522f127a08dfa02b888149ecca7fe972a4e2

Head commit of repository kde: f4a5563c2bcc5b9cfa1f18d17e62bcca843320f0

Head commit of repository libressl: 2119e6cd984bbb640b6a1d0234701bbafb7040de

Head commit of repository ppfeufer-gentoo-overlay: 5749229ec696bb81349413e44ac1f1ce33f2c28c

Head commit of repository qt: c5a8bc30c940374a54bac471f8c116c14448c9cf

Head commit of repository science: a5c0e85c0b92a96ebc391eafe31361f2ad797187

Head commit of repository steam-overlay: ae3e928b83b722ae6197fc1bc78859b592b819e5

Head commit of repository vortex: 8931128e6e38ecb710833b19cf06cd5f562a040d

sh bash 5.0_p17
ld GNU ld (Gentoo 2.34 p4) 2.34.0
app-shells/bash:          5.0_p17::gentoo
dev-lang/perl:            5.30.2-r2::gentoo
dev-lang/python:          2.7.18::gentoo, 3.7.7-r2::gentoo, 3.8.3::gentoo, 3.9.0_beta1::gentoo
dev-util/cmake:           3.17.3::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.2::gentoo
sys-devel/binutils:       2.34-r1::gentoo
sys-devel/gcc:            10.1.0::gentoo
sys-devel/gcc-config:     2.3::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.6::gentoo (virtual/os-headers)
sys-libs/glibc:           2.31-r3::gentoo
Repositories:

gentoo
    location: /archive/gentoo/etc/portage/repos/gentoo
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/repo/gentoo.git
    priority: 0

Installed sets:
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CC="clang"
CFLAGS="-march=native -O3 -pipe -ferror-limit=0 -rtlib=compiler-rt -Wno-unused-command-line-argument -Wno-unused-variable"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXX="clang++"
CXXFLAGS="-march=native -O3 -pipe -ferror-limit=0 -rtlib=compiler-rt -Wno-unused-command-line-argument -Wno-unused-variable -stdlib=libc++"
DISTDIR="/etc/portage/distfiles"
EMERGE_DEFAULT_OPTS="--jobs=12 --load-average=12 -a --autounmask=n --columns --complete-graph=n --fail-clean=y --quiet-fail=n --quiet-unmerge-warn"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox parallel-fetch pid-sandbox preserve-libs qa-unresolved-soname-deps sandbox sfperms split-log strict test unknown-features-warn unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org /etc/portage/mirror"
LANG="en_US.utf8"
LDFLAGS="-Xcompiler -fuse-ld=lld -Wl,-O1 -Wl,--as-needed -Wl,--error-limit=0 -Wl,--threads"
LINGUAS=""
MAKEOPTS="--jobs=12 --load-average=12"
PKGDIR="/etc/portage/distfiles/bin"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/etc/portage/tmp"
USE="aes amd64 avx avx2 berkdb bzip2 cli crypt dri f16c fma3 fortran gdbm iconv libtirpc mmx mmxext multilib ncurses nls nptl openmp pam pclmul pcre popcnt readline split-usr sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssse3 tcpd test unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="hda-intel usb-audio" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="*" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" CURL_SSL="libressl" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput wacom" KERNEL="linux" L10N="*" LLVM_TARGETS="NVPTX" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python3_7" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 unhappy-ending 2020-06-02 02:26:12 UTC
Created attachment 643100 [details]
pre-patch failure and post-patch success build logs
Comment 3 Andreas Sturmlechner gentoo-dev 2020-06-02 09:09:06 UTC
Please submit your patch upstream.
Comment 4 Andreas Sturmlechner gentoo-dev 2020-06-02 09:12:24 UTC
Before that though, please make sure your user patch is not the problem here.

>  * Applying kwin-lowlatency-5.18.5.patch ...
>  [ ok ]
Comment 5 unhappy-ending 2020-06-02 09:49:43 UTC
I'm 99% sure I tested it on vanilla without the low-latency patch but I just double checked and the failure still happens without. How do I upstream the patch?
Comment 6 Andreas Sturmlechner gentoo-dev 2020-06-02 10:45:13 UTC
Submitting a merge request in their dev repository:

https://invent.kde.org/plasma/kwin/-/merge_requests