### there are two issues with xorg-x11-6.8.0, see "Actural Results" Reproducible: Always Steps to Reproduce: ### 1. emerge xtrlock Actual Results: ### First Trial: >>> emerge (1 of 1) x11-misc/xtrlock-2.0-r1 to / >>> md5 src_uri ;-) xtrlock_2.0-6.tar.gz >>> Unpacking source... >>> Unpacking xtrlock_2.0-6.tar.gz to /var/tmp/portage/xtrlock-2.0-r1/work * Applying xtrlock-2.0-overflow.patch ... [ ok ] >>> Source unpacked. imake -DUseInstalled -I/usr/X11R6/lib/X11/config In file included from /usr/X11R6/lib/X11/config/Imake.tmpl:105, from Imakefile.c:35: /usr/X11R6/lib/X11/config/linux.cf:371: warning: "BuildLibGlxWithoutPIC" redefined In file included from /usr/X11R6/lib/X11/config/site.def:44, from /usr/X11R6/lib/X11/config/Imake.tmpl:46, from Imakefile.c:35: /usr/X11R6/lib/X11/config/host.def:63: warning: this is the location of the previous definitio n i686-pc-linux-gnu-gcc -O3 -march=athlon-xp -mmmx -msse -m3dnow -pipe -DSHADOW_PWD -c -o xtrl ock.o xtrlock.c xtrlock.c: In function `main': xtrlock.c:205: error: label at end of compound statement make: *** [xtrlock.o] Error 1 ### 2nd Trial: (corrected "BuildLibGlxWithoutPIC" redefined problem with "if notdefined" statement) >>> emerge (1 of 1) x11-misc/xtrlock-2.0-r1 to / *** Adjusting cvs-src permissions for portage user... >>> md5 src_uri ;-) xtrlock_2.0-6.tar.gz >>> Unpacking source... >>> Unpacking xtrlock_2.0-6.tar.gz to /var/tmp/portage/xtrlock-2.0-r1/work * Applying xtrlock-2.0-overflow.patch ... [ ok ] >>> Source unpacked. imake -DUseInstalled -I/usr/X11R6/lib/X11/config i686-pc-linux-gnu-gcc -march=athlon-xp -O3 -pipe -mmmx -msse -m3dnow -DSHADOW_PWD -c -o xtrlock.o xtrlock.c xtrlock.c: In function `main': xtrlock.c:205: error: label at end of compound statement make: *** [xtrlock.o] Error 1 Expected Results: ### It should compile
### FIX-Patch: diff -urN ../tmp-orig/xtrlock-2.0/xtrlock.c ./xtrlock.c --- ../tmp-orig/xtrlock-2.0/xtrlock.c 2002-09-01 06:46:29.000000000 +0200 +++ ./xtrlock.c 2004-08-07 14:34:11.501808518 +0200 @@ -203,7 +203,6 @@ break; } break; - default: } } loop_x:
the fix here is simple ... add a ; where it belongs in this case, xtrlock.c needs to have a ';' added after the 'default:' label at the end of the file
No one has fixed this in Portage yet. I have already patched this and compiled it on my system. It has been tested and works fine, of course (so simple). Can a developer PLEASE update the portage tree? I can help if you'd like (I have a patch and a patched ebuild). Let me know, thanks!
Bump... Anyone with commit access care to fix this? This application will NOT compile on any newer Gentoo profile without C coding and/or ebuild hacking. Again, I'll help by providing all of the files if you'd like: - Patched ebuild - Patch file Thanks.
Created attachment 54287 [details, diff] Patch to fix broken default label in switch statement - line 204 This patch adds the needed semi-colon on the end of the trailing "default" label in the "main" method.
Created attachment 54288 [details] Ebuild file to include the broken-label patch This is the patched ebuild file for this package. It includes the needed epatch statement to add the "broken-label" patch (already submitted). Note: Since I use amd64, that keyword is in this ebuild. There is currently another open bug/task to add the adm64 keyword to this ebuild, since it compiles and works just fine.
Is there nobody to put all the fixes together and bring it into portage please? tnx in advance!
OKAY, after a sync i noticed the ebuild is working on my x86 and also with my amd64, i set the bug to FIXED now, tnx anybody! Only thing we would maybe need is an fancy .xpm icon ;) (maybe someone could capture the nice lock?)
