With bad-block relocation turned on, compiling the kernel ends in an error complaining about a macro located in dm-bbr.c Reproducible: Always Steps to Reproduce: 1. cd /usr/src/linux 2. make menuconfig and enable device-mapper support and bad-block relocation 3. make Actual Results: Get this error CC [M] drivers/md/dm-bbr.o drivers/md/dm-bbr.c:962:39: macro "create_workqueue" requires 2 arguments, but only 1 given drivers/md/dm-bbr.c: In function `dm_bbr_init': drivers/md/dm-bbr.c:962: error: `create_workqueue' undeclared (first use in this function)drivers/md/dm-bbr.c:962: error: (Each undeclared identifier is reported only once drivers/md/dm-bbr.c:962: error: for each function it appears in.) make[2]: *** [drivers/md/dm-bbr.o] Error 1 make[1]: *** [drivers/md] Error 2 make: *** [drivers] Error 2 Expected Results: Compiled cleanly Portage 2.0.51-r3 (default-linux/x86/2004.0, gcc-3.4.3, glibc-2.3.4.20041102-r0, 2.6.9-gentoo-r3 i686) ================================================================= System uname: 2.6.9-gentoo-r3 i686 AMD Athlon(tm) processor Gentoo Base System version 1.6.6 distcc 2.18.2 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled] ccache version 2.3 [enabled] Autoconf: sys-devel/autoconf-2.59-r5 Automake: sys-devel/automake-1.8.5-r1 Binutils: sys-devel/binutils-2.15.92.0.2-r1 Headers: sys-kernel/linux26-headers-2.6.8.1-r1 Libtools: sys-devel/libtool-1.5.2-r7 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CFLAGS="-march=athlon -O3" CHOST="i686-pc-linux-gnu" COMPILER="" CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-march=athlon -O3" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms" GENTOO_MIRRORS="ftp:///ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ http://mirror.datapipe.net/gentoo http://open-systems.ufl.edu/mirrors/gentoo http://mirror.datapipe.net/gentoo"MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="3dnow 3dnowex X acl acpi acpi4linux aim alsa apm atlas avi berkdb bitmap-fonts blas bonobo cairo cddb cdparanoia cdr cdrom chroot clisp crypt cscope cups dio directfb divx4linux djbfft dnd dts dv dvd dvdr dvdread eds encode erandom evms2 evo exif f77 faac faad fam fastcgi fbcon ffmpeg fftw flac foomaticdb fortran freetype ftp gb gd gdbm gif gimp gimpprint ginac gnome gnomedb gnuplot gphoto2 gpm gsl gstreamer gtk gtk2 gtkhtml guile hal hbci hdf5 icq ieee1394 imagemagick imap imlib ipv6 irda jabber java javascript jikes joystick jpeg junit kde lcms libwww lirc lufsusermount mad maildir matroska mcal mikmod mime mmap mmx mmx2 motif mozilla mozsvg mp3 mpeg mpeg4 mpi mplayer mysql ncurses nls nptl nvidia odbc ofx oggvorbis openal opengl opie oss pam pcre pda pdf pdflib perl pic plotutils png posix postgres ppds python qt quicktime quotes readline rtc samba scanner sdl slang sndfile snortsam spamassassin spell sse ssl stroke svg svga tcltk tcpd tetex theora tiff transcode truetype usb v4l v4l2 vnc wmf x86 xfs xine xinerama xml xml2 xmms xosd xrandr xsl xv xvid xvmc zlib"
Does it work with the vanilla kernel?
stefan, dm-bbr isnt in vanilla. looking into it.
Can't reproduce here on gcc-3.4.3 Please upload your .config (as attachment)
Created attachment 45030 [details] .config for the kernel Attached is .config used for gentoo-dev-sources-r6 (and r3, which I am currently using)
Not getting any problems with that config either. Can someone else please try to reproduce this?
I got a clean compile on gentoo-dev-sources-r9. And I think I tracked down what was originally conflicting for me on r6 (and is still a problem for r9). In a nutshell, one of the patches from software-suspend-2.1.5 (which I forgotten I had applied[sheepish grin]) modifies the dm-bbr patch in a bad way. Even though they apply clean (with no rejected hunks), the resulting kernel source tree will not compile and spits out the errors detailed on the original bugreport. I compiled with and without the software-suspend patches: without and everything is fine, with and I get the bad kernel compile. Unfortunately, I have a 500GB EVMS array that I built using BBR policies on the partitions, so I can't have that work and software suspend work at the same time. (guess I'll wait for the guru hackers to figure this one out) Thanks for all the help, I appreciate everyone looking into it.
Sorry, can't really support it if you apply broken patches to our tree :)
