Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 725710 - doebuild.py: validate_desktop_entry should check .desktop files in /usr/share/xsessions too
Summary: doebuild.py: validate_desktop_entry should check .desktop files in /usr/share...
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-28 07:07 UTC by Jeroen Roovers (RETIRED)
Modified: 2020-05-28 07:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2020-05-28 07:07:15 UTC 
A recent unreleased change in x11-wm/herbstluftwm fixes a desktop-file-validate error in (what is to be installed as) /usr/share/xsessions/herbstluftwm.desktop, and indeed on the latest release 0.8.2, desktop-file-validate invalidates the file in question:

$ desktop-file-validate /usr/share/xsessions/herbstluftwm.desktop
/usr/share/xsessions/herbstluftwm.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
/usr/share/xsessions/herbstluftwm.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")

I guess doebuild.py should check that path as well? This catches quite a few errors:

/usr/share/xsessions/herbstluftwm.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")
/usr/share/xsessions/i3.desktop: error: file contains key "DesktopNames" in group "Desktop Entry", but keys extending the format should start with "X-"
/usr/share/xsessions/icewm.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")
/usr/share/xsessions/icewm.desktop: error: value "WindowManager;Application;System;" for key "Categories" in group "Desktop Entry" contains an unregistered value "WindowManager"; values extending the format should start with "X-"
/usr/share/xsessions/icewm.desktop: error: file contains key "DesktopNames" in group "Desktop Entry", but keys extending the format should start with "X-"
/usr/share/xsessions/icewm.desktop: error: file contains group "Window Manager", but groups extending the format should start with "X-"
/usr/share/xsessions/icewm-session.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")
/usr/share/xsessions/icewm-session.desktop: error: value "WindowManager;Application;System;" for key "Categories" in group "Desktop Entry" contains an unregistered value "WindowManager"; values extending the format should start with "X-"
/usr/share/xsessions/icewm-session.desktop: error: file contains key "DesktopNames" in group "Desktop Entry", but keys extending the format should start with "X-"
/usr/share/xsessions/icewm-session.desktop: error: file contains group "Window Manager", but groups extending the format should start with "X-"
/usr/share/xsessions/pekwm.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")
/usr/share/xsessions/subtle.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and
"Directory")
/usr/share/xsessions/wmfs.desktop: error: required key "Type" in group "Desktop Entry" is not present


so I wonder if adding checks for /usr/share/xsessions/*.desktop is plausible at all.