Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 724224 - net-libs/libtorrent-rasterbar: consider enabling "logging" by default
Summary: net-libs/libtorrent-rasterbar: consider enabling "logging" by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-20 00:23 UTC by WGH
Modified: 2020-06-07 10:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description WGH 2020-05-20 00:23:17 UTC
Currently, the ebuilds are written in such way that "logging" configure option is only enabled when "debug" USE flag is enabled.

local myeconfargs=(
	$(use_enable debug)
	$(use_enable debug export-all)
	$(use_enable debug logging)
	$(use_enable dht)
	$(use_enable examples)
	$(use_enable ssl encryption)
	$(use_enable static-libs static)
	$(use_enable test tests)
	--with-boost="${EPREFIX}/usr"
	--with-libiconv
)

It differs from both upstream default, and how other distributions (e.g. Debian) package it. The logging option affects which events ("alerts") are generated by the library. Some of them are useful to library users. http://libtorrent.org/reference-Alerts.html#alert-category-t

On the other hand, enabling debug also enables some extra checks, that lead to assertion failure crashes[1][2]. Of course, these crashes are most likely bugs that were undiscovered because no one running libtorrent with invariant checking, but the end result right now is that you either have missing alert types, or broken Bittorrent client that you routinely use.

[1] https://github.com/arvidn/libtorrent/issues/4665
[2] https://github.com/qbittorrent/qBittorrent/issues/12867

Reproducible: Always
Comment 1 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2020-06-07 10:48:16 UTC
Makes sense. Added unconditionally.