723308 – The USE_EXPAND flags on package show are labelled with the first USE_EXPAND association found.

Bug 723308 - The USE_EXPAND flags on package show are labelled with the first USE_EXPAND association found.

Summary: The USE_EXPAND flags on package show are labelled with the first USE_EXPAND a...

Status:	RESOLVED FIXED

Alias:	None

Product:	Websites
Classification:	Unclassified
Component:	Packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Packages Website

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2020-05-16 02:38 UTC by Alec Warner
Modified:	2020-05-18 00:37 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alec Warner (RETIRED) archtester

2020-05-16 02:38:42 UTC

This is due to a flattening of the data model in package/utils.go: getPackageUseflags.

It returns a list of models.useFlags and later during template expansion we just say "these are all associated with {{ (index .UseExpands 0).UseExpand}}".

There is a TODO to group-by, we should likely just change this to a map[string][]models.useFlag data struction.

Then in the template we just iterate over the keys and for each value, emit the flag.

Comment 1 Michael 'veremitz' Everitt 2020-05-17 23:23:34 UTC


*** This bug has been marked as a duplicate of bug 717772 ***

Comment 2 Alec Warner (RETIRED) archtester

2020-05-18 00:37:49 UTC

This bug is fixed in prod.

-A