Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 72327 - Couple changes regarding python.eclass
Summary: Couple changes regarding python.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High minor (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-24 02:26 UTC by Aaron Walker (RETIRED)
Modified: 2005-04-22 22:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
python.eclass.diff (python.eclass.diff,1.92 KB, patch)
2004-11-24 02:27 UTC, Aaron Walker (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Walker (RETIRED) gentoo-dev 2004-11-24 02:26:37 UTC
While writing a manual page for python.eclass, I noticed a few things that IMO should be changed.  Most of the changes are regarding launching external commands for stuff that can easily be done with bash (ie.  the sleu of "echo ... | sed ..." constructs that can easily be accomplished via parameter substitution).

A diff is attached.  You guys (of course) are free to dismiss this bug and close WONTFIX, since obviously you guys are the experts on this eclass, not me.

Cheers
Comment 1 Aaron Walker (RETIRED) gentoo-dev 2004-11-24 02:27:00 UTC
Created attachment 44625 [details, diff]
python.eclass.diff
Comment 2 Alastair Tse (RETIRED) gentoo-dev 2005-04-20 08:43:20 UTC
sorry for taking so long. i guess i never saw this bug, but they are all good fixes to my lack of bash-fu skills. thanks for the patch.

committing to cvs.
Comment 3 Kyle McFarland 2005-04-22 21:56:44 UTC
Small Problem with the changes to python_version() in the new python.eclass. if python -V returns a version with only a major and minor version ${PYVER} and ${PYVER_MINOR} will be incorrect. for example with python 2.4 ${PYVER} will end up being 2 instead of 2.4 and ${PYVER_MINOR} will end up being 2 as ${PYVER} doesn't contain the minor version number
Comment 4 Rob Cakebread (RETIRED) gentoo-dev 2005-04-22 22:51:03 UTC
See #90092