Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 721710 - =media-libs/avidemux-plugins-2.7.4 runs also with Py 3.7 and Py 3.8
Summary: =media-libs/avidemux-plugins-2.7.4 runs also with Py 3.7 and Py 3.8
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-08 22:42 UTC by Christian Tietz
Modified: 2021-01-10 13:54 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Disable python plugin (dispable-python.patch,1.26 KB, patch)
2020-05-10 07:29 UTC, poncho
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Tietz 2020-05-08 22:42:40 UTC
I've tried with both Py 3.7 and 3.8 and it seems to work fine. Please update. Thanks

Reproducible: Always
Comment 1 Jonas Stein gentoo-dev 2020-05-09 20:50:34 UTC
how did you test it exactly? Were there test units? Can you provide logs?
Comment 2 Christian Tietz 2020-05-09 21:16:24 UTC
I simply added 3_7 and 3_8 to PYTHON_COMPAT and did some runtime testing. Of course this should be tested thoroughly before it enters the tree. Please consider this rather a proposal than a solution with logs attached and what not.
Comment 3 poncho 2020-05-10 07:15:17 UTC
I don't think there is a test suite.

Both examples from https://www.avidemux.org/admWiki/doku.php?id=tinypy:avidemux#example do work with python 3.7
Comment 4 poncho 2020-05-10 07:29:39 UTC
Created attachment 637248 [details, diff]
Disable python plugin

Another possibility would be to disable the python plugin
Comment 5 William T Wilson 2020-05-10 12:24:07 UTC
Disabling the python plugin is not a good choice.  Avidemux python support is based on tinypy, an included mini-interpreter written in C that, as distributed with avidemux, doesn't depend on the system interpreter.  But many uses of avidemux depend on tinypy scripts, and disabling it would make users unhappy.

I don't believe the system python is needed by avidemux-plugins *at all*.  Most of the python scripts that are included with the avidemux distribution are for use with the included tinypy interpreter, and the remainder are used by the avidemux developers for code generation (and not needed at compile time as the generated C/C++ code is included in the distribution) or are system-specific build scripts (e.g. for Mac) that aren't used by Gentoo.

Avidemux documentation does not indicate any kind of Python as a dependency.

I don't think avidemux actually has any python dependency, and the right choice is to simply remove the declaration in the ebuild.  I don't know how to test it, as I don't know how to create a Gentoo environment that doesn't have any Python in it.

Of course something must be done so that 3.6 can be removed.  For some time this package has been the only thing tying me to 3.6.
Comment 6 Ulenrich 2020-08-10 08:57:50 UTC
Ping.
What William T Wilson tells
implies Christian Tietz claim is right:
> I've tried with both Py 3.7 and 3.8 and it seems to work fine. Please update. 

You cannot test Py 3.7 when it is not used. At least a masked new version for testing with compat python3_7 should be available for users to test.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-11 07:30:26 UTC
(In reply to Ulenrich from comment #6)
> You cannot test Py 3.7 when it is not used. At least a masked new version
> for testing with compat python3_7 should be available for users to test.

You could in an overlay.
Comment 8 jospezial 2020-09-19 00:22:33 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58216c5b068cda416017ab8311484361e0e9261c
"media-libs/avidemux-plugins: bump to v2.7.6"
PYTHON_COMPAT=( python3_{6,7,8,9} )


media-libs/avidemux-plugins ebuild still depends on dev-lang/spidermonkey:0=
which depends on Python 2.7 .

I have tried a media-libs/avidemux-plugins live ebuild with only dev-lang/spidermonkey-78.2.0::gentoo installed.
When should I see an error? Where is it used?


media-libs/avidemux-plugins with dev-lang/spidermonkey is/was the last python 2.7 dependency on my system.
polkit now uses latest dev-lang/spidermonkey