Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 71993 - patch to fix sound in zsnes cvs for me.
Summary: patch to fix sound in zsnes cvs for me.
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-21 15:38 UTC by Mikael Magnusson
Modified: 2004-11-22 17:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
v1 (fixsound.diff,1.67 KB, patch)
2004-11-21 15:45 UTC, Mikael Magnusson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Magnusson 2004-11-21 15:38:44 UTC
The sound in zsnes has been sort of skippy and missing notes for a few months now, so i looked around a bit on their forums and the cvs commits, and found a suspicious commit in sdllink.c, reverting it fixed the issues i had. Maybe someone else has them too?

Reproducible: Always
Steps to Reproduce:
1. start a game in zsnes
2. make sure sound is on
3. play some music in the game

Actual Results:  
The music and sound was irregular and skippy.

Expected Results:  
Play it like it normally.

will attach patch.
Comment 1 Mikael Magnusson 2004-11-21 15:45:16 UTC
Created attachment 44442 [details, diff]
v1

basically reverses revision change 1.134->1.135 in sdllink.c with this commit
message,

2003-05-19 03:43  pagefault

	* src/linux/sdllink.c: Fixes audio problems on broken drivers
	  (Diablo-D3)

so obviously it was meant to fix something, but it works better for me without
it.
Comment 2 Mikael Magnusson 2004-11-21 15:48:29 UTC
also see this thread if you want, http://board.zsnes.com/phpBB2/viewtopic.php?p=22864
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2004-11-22 17:18:07 UTC
I admit I'm not super excited about adding this patch to portage since the sound in znses works fine for me.  I can see that there are several people in the forum link that have issues but I'd like it to be worked out upstream until there is another release of zsnes.  I'm going to mark this as WONTFIX but feel free to attach an ebuild that uses this patch for people to put in their overlays.  Thanks.