Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 71845 - Bunch of Enhancements for isdn4k-utils (and some other tools)
Summary: Bunch of Enhancements for isdn4k-utils (and some other tools)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-20 07:36 UTC by Stefan Briesenick (RETIRED)
Modified: 2004-11-24 01:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
isdn4k-utils-3.5_p20041110.tar.bz2 (isdn4k-utils-3.5_p20041110.tar.bz2,2.97 KB, application/octet-stream)
2004-11-20 07:38 UTC, Stefan Briesenick (RETIRED)
Details
isdn4k-ipppd-3.5_p20041110.tar.bz2 (isdn4k-ipppd-3.5_p20041110.tar.bz2,4.20 KB, application/octet-stream)
2004-11-20 07:39 UTC, Stefan Briesenick (RETIRED)
Details
isdn4k-isdnlog-3.5_p20041110.tar.bz2 (isdn4k-isdnlog-3.5_p20041110.tar.bz2,3.76 KB, application/octet-stream)
2004-11-20 07:39 UTC, Stefan Briesenick (RETIRED)
Details
isdn4k-eft-3.5_p20041110.tar.bz2 (isdn4k-eft-3.5_p20041110.tar.bz2,2.07 KB, application/octet-stream)
2004-11-20 07:41 UTC, Stefan Briesenick (RETIRED)
Details
capi4k-firmware-2004.4.5-r1.tar.bz2 (capi4k-firmware-2004.4.5-r1.tar.bz2,928 bytes, application/octet-stream)
2004-11-20 07:43 UTC, Stefan Briesenick (RETIRED)
Details
vbox3-0.1.9.tar.bz2 (vbox3-0.1.9.tar.bz2,1.62 KB, application/octet-stream)
2004-11-20 07:44 UTC, Stefan Briesenick (RETIRED)
Details
raccess4vbox3-0.2.8.tar.bz2 (raccess4vbox3-0.2.8.tar.bz2,827 bytes, application/octet-stream)
2004-11-20 07:45 UTC, Stefan Briesenick (RETIRED)
Details
ivam2-0.3.tar.bz2 (ivam2-0.3.tar.bz2,1.47 KB, application/octet-stream)
2004-11-20 07:46 UTC, Stefan Briesenick (RETIRED)
Details
ivcall-0.3.tar.bz2 (ivcall-0.3.tar.bz2,853 bytes, application/octet-stream)
2004-11-20 07:47 UTC, Stefan Briesenick (RETIRED)
Details
capifwd-0.6.3.tar.bz2 (capifwd-0.6.3.tar.bz2,1.75 KB, application/octet-stream)
2004-11-20 07:48 UTC, Stefan Briesenick (RETIRED)
Details
big-bunch-for-easy-download.tar.bz2 (big-bunch-for-easy-download.tar.bz2,11.56 KB, application/octet-stream)
2004-11-20 09:13 UTC, Stefan Briesenick (RETIRED)
Details
isdn4k-utils-3.5_p20041110.tar.bz2 (isdn4k-utils-3.5_p20041110.tar.bz2,7.12 KB, application/octet-stream)
2004-11-21 15:10 UTC, Stefan Briesenick (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:36:55 UTC
Ok folks. Now I attach my promised enhancements. Since most ebuilds depends on some files in $FILESDIR, I attach them as tar.bz2's so all things are kept together.

These Ebuilds are tested by me and they work perfectly on my system. But since there're lot of changes to the original ebuild(s), they should be tested before putting them into portage.

ok, gimme 1/2 hr to attach all that stuff. ;-)


Reproducible: Always
Steps to Reproduce:
Comment 1 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:38:38 UTC
Created attachment 44350 [details]
isdn4k-utils-3.5_p20041110.tar.bz2

*  net-dialup/isdn4k-utils
      Latest version available: 3.5_p20041110
      Latest version installed: 3.5_p20041110
      Size of downloaded files: 5,382 kB
      Homepage:    http://www.isdn4linux.de/
      Description: ISDN4Linux Utils (base package)
      License:	   GPL-2
Comment 2 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:39:17 UTC
Created attachment 44351 [details]
isdn4k-ipppd-3.5_p20041110.tar.bz2

*  net-dialup/isdn4k-ipppd
      Latest version available: 3.5_p20041110
      Latest version installed: 3.5_p20041110
      Size of downloaded files: 5,382 kB
      Homepage:    http://www.isdn4linux.de/
      Description: ISDN4Linux IPPPD (isdn networking)
      License:	   GPL-2
Comment 3 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:39:48 UTC
Created attachment 44352 [details]
isdn4k-isdnlog-3.5_p20041110.tar.bz2

*  net-dialup/isdn4k-isdnlog
      Latest version available: 3.5_p20041110
      Latest version installed: 3.5_p20041110
      Size of downloaded files: 5,382 kB
      Homepage:    http://www.isdn4linux.de/
      Description: ISDN4Linux ISDNLOG (isdn log system)
      License:	   GPL-2
Comment 4 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:41:40 UTC
Created attachment 44354 [details]
isdn4k-eft-3.5_p20041110.tar.bz2

*  net-dialup/isdn4k-eft
      Latest version available: 3.5_p20041110
      Latest version installed: 3.5_p20041110
      Size of downloaded files: 5,382 kB
      Homepage:    http://www.isdn4linux.de/
      Description: ISDN4Linux EFT (Euro-File-Transfer)
      License:	   GPL-2

ATTENTION: experiemental package. Needs still some work. But I attach it, so we
can do this job together. It compiles and installes perfectly, but we need an
init-script and x25-utils.
Comment 5 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:43:20 UTC
Created attachment 44355 [details]
capi4k-firmware-2004.4.5-r1.tar.bz2

*  net-dialup/capi4k-firmware
      Latest version available: 2004.4.5-r1
      Latest version installed: 2004.4.5-r1
      Size of downloaded files: 2,453 kB
      Homepage:    http://www.isdn4linux.de/
      Description: Firmware files for active AVM ISDN controllers
      License:	   as-is

HINT: I removed all firmware files which are already installed by isdn4k-utils
to avoid dupes.
Comment 6 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:44:45 UTC
Created attachment 44356 [details]
vbox3-0.1.9.tar.bz2

*  net-dialup/vbox3
      Latest version available: 0.1.9
      Latest version installed: 0.1.9
      Size of downloaded files: 103 kB
      Homepage:    http://smarden.org/pape/
      Description: ISDN voice response system for Linux
      License:	   GPL-2
Comment 7 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:45:20 UTC
Created attachment 44357 [details]
raccess4vbox3-0.2.8.tar.bz2

*  net-dialup/raccess4vbox3
      Latest version available: 0.2.8
      Latest version installed: 0.2.8
      Size of downloaded files: 742 kB
      Homepage:    http://smarden.org/pape/
      Description: Add-on to vbox3 (ISDN voice response system)
      License:	   GPL-2
Comment 8 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:46:14 UTC
Created attachment 44358 [details]
ivam2-0.3.tar.bz2

*  net-dialup/ivam2
      Latest version available: 0.3
      Latest version installed: 0.3
      Size of downloaded files: 299 kB
      Homepage:    http://0pointer.de/lennart/projects/ivam2/
      Description: Automatic phone answering machine software for ISDN
      License:	   GPL-2
Comment 9 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:47:21 UTC
Created attachment 44359 [details]
ivcall-0.3.tar.bz2

*  net-dialup/ivcall
      Latest version available: 0.3
      Latest version installed: 0.3
      Size of downloaded files: 89 kB
      Homepage:    http://0pointer.de/lennart/projects/ivcall/
      Description: Utility which may be used to make automated telephone calls
via ISDN
      License:	   GPL-2
Comment 10 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:48:06 UTC
Created attachment 44360 [details]
capifwd-0.6.3.tar.bz2

*  net-dialup/capifwd
      Latest version available: 0.6.3
      Latest version installed: 0.6.3
      Size of downloaded files: 80 kB
      Homepage:    http://capi20proxy.sourceforge.net/
      Description: A daemon forwarding capi messages to capi20proxy clients
      License:	   GPL-2
Comment 11 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 07:50:35 UTC
ok, finished. ;-)

attention: the init-script in isdn4k-utils was renamed from 'isdn4linux' to 'isdn'. Most distributions use 'isdn' for it, so it's better to also use this name. And it's more similar to /etc/init.d/capi.
Comment 12 Stefan Schweizer (RETIRED) gentoo-dev 2004-11-20 08:42:30 UTC
Why did you split up isdn4k-utils? capi4k-firmware has already a -r1 now :), please look at the changes in it, /lib/firmware has to be used for firmware files, but we still create symlinks for /usr/lib/isdn. And it would be imo better if you would also provide diffs for the already in portage files, the rest should imo have gone into one big tarball for easy downloading :)
Comment 13 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 09:12:32 UTC
1. I splitted isdn4k-utils, because you don't need all that stuff if you have CAPI running. So you can decide what you want. Other distris also split that stuff. And it's ok this way.

2. I will attach a "big" tar.bz2 for easy downloading

3. diff's aren't practical, since these ebuilds are mostly a *complete* rewrite. the diff would be bigger than the ebuild.
Comment 14 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 09:13:54 UTC
Created attachment 44367 [details]
big-bunch-for-easy-download.tar.bz2
Comment 15 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 09:20:32 UTC
btw: the split has also the BIG advantage, that one can improve the extra apps indepentantly. Have a look at my ebuild. This was really hard work to get all that stuff running perfectly.

That all these apps are part of isdn4k-utils means nothing. It's just a big melting pot and you have to pick up all the goodies. ;-)
Comment 16 Stefan Schweizer (RETIRED) gentoo-dev 2004-11-20 09:31:44 UTC
Your capi4k-firmware still needs to apply to the latest changes for that package.
isdn4k-utils does not coompile here:

gcc -Wall -march=i586 -fomit-frame-pointer -pipe -Os -DUNIX -DLINUX -I. -Iinclude -DEICONCTRL eiconctrl.o ./divautil/lindiload.o ./divautil/linload.o ./divautil/lindownload.o ./divautil/xlog.o linuxcfg.o -L../lib -lncurses  -o eiconctrl 
eiconctrl.o(.text+0x2786): In function `main':
: undefined reference to `xlog'
collect2: ld returned 1 exit status
make[1]: *** [eiconctrl] Error 1
make[1]: *** Waiting for unfinished jobs....
gcc -Wall -march=i586 -fomit-frame-pointer -pipe -Os -DUNIX -DLINUX -I. -Iinclude -DDATADIR=\"/usr/share/isdn\" -c -o linuxcfg.o linuxcfg.c  
make[1]: *** Waiting for unfinished jobs....
gcc -Wall -march=i586 -fomit-frame-pointer -pipe -Os -DUNIX -DLINUX -I. -Iinclude ./divautil/divalog.o ./divautil/loglib.o ./divautil/idilog.o ./divautil/xlog.o linuxcfg.o -L../lib -lncurses  -o divalog
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/isdn4k-utils-3.5_p20041110/work/isdn4k-utils-CVS-2004-11-10/eicon'
make: *** [subtargets] Error 2
Comment 17 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 09:41:45 UTC
wuahhh! I tested the "new" capi4-firmware in portage.

why do you rename all the firmware-files? these files are handled by capiinit only and even with a symlink, it's crazy to rename them. :-/

furthermore: you still install dupes.

all files, but the AVM ones, are installed by isdn4k-utils. We really only need the AVM ones!
Comment 18 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 09:42:52 UTC
another option would be, to have a general isdn-firmware for both capi and isdn and then we kick the firmware in isdn4k-utils.

Comment 19 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 09:44:21 UTC
@stefan: mom, I check your problem.

I installed the latest capi4k-firmware in portage. Kick my version attached here for the time beeing.
Comment 20 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 09:50:38 UTC
ok, isdn4k-utils compiles and works on two of my machines. Looks like a missing dependency. Now we have to figure out, which package this could be. ;-)

I found this:
/usr/lib/libxlog.a
/usr/include/xfs/libxlog.h

and this is part of xfsprogs-2.6.25

but this makes to sense to me. But please try it!
Comment 21 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 09:54:23 UTC
no. removing xfsprogs and re-emerging isdn4k-utils still works. Seems to be a local problem on your PC.
Comment 22 Stefan Schweizer (RETIRED) gentoo-dev 2004-11-20 11:03:57 UTC
I know where it comes from, now. It liks the file too early and the needed .o are not yet created. Do you have any idea, why this could be so?
Comment 23 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 11:59:06 UTC
src_compile() {
        make subconfig || die
        emake || die
}

try to change "emake" to "make" and it should work. I regognized such problems with isdnlog and there I changed it this way and it worked then.
Comment 24 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-20 12:01:43 UTC
emake is generally better, because it enables parallel compiling and distcc and is somewhat faster. But in this case it seems to be bad. I had no problems with other builds than isdnlog. But if you can fix it with "make" then it's ok.
Comment 25 Alin Năstac (RETIRED) gentoo-dev 2004-11-21 01:20:09 UTC
stefan, what problem do you have with firmware files in the new capi4k-firmware?
all that it does is to install real files in /lib/firmware (for consistency with other ebuilds) and symlink them in /usr/lib/isdn (path that is used by capi4k-utils for firmware files).
capi4k-utils does not install any firmware file.

If you can, pls see me on irc.
Comment 26 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-21 02:21:53 UTC
@Alin: the new firmware ebuild technically works. But it makes no sense this way and it's really ugly to rename the files. And none of the firmwares in that package are loaded via hotplug but with capiinit.

So you made a solution for a non-existing problem.

But hey, forget the firmware "problem" for the time beeing. First we should handle the other things above. ;-) Then, at last, we have still time enough to fix minor issues.
Comment 27 Stefan Schweizer (RETIRED) gentoo-dev 2004-11-21 02:37:05 UTC
I created a new package called fritzcapi, for all the avm passive cards drivers. But the firmwares (for fcusb eg) are missing, so it would be nice, to have them added to capi4k-firmware, and of course it would be nice then, to have hotplug load this fcusb firmware (I dont know where to put the hotplug script though).

See the fritzcapi pkg in portage (only module compilation)
http://bugs.gentoo.org/show_bug.cgi?id=52984
for the fcubs2 pkg. To make it possible to use the fcusb with fritzcapi, we would need to add hotplug script and firmware from another pkg.
Comment 28 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-21 02:57:40 UTC
ok, it makes sense to put all capi-firmware into one single package. But it should be done carefully.

A friend of mine owns a Fritz! Card USB. He gets DSL in a few days, so I could ask him to give me his device to a few days for testing purposes. But first he needs DSL. ;-)

But as I said before, most imortant is to put my isdn4k-utils into portage, because it's the bridge between "old" and "new" world and I introduced some changes which could affect further optimizations in other ebuilds.

I mean: isdn4k-utils, isdn4k-ipppd and isdn4k-isdnlog, eventually vbox3 and raccess4vbox3

the others are not so important for the time beeing, because they're new ebuilds.
Comment 29 Alin Năstac (RETIRED) gentoo-dev 2004-11-21 10:29:14 UTC
vbox3 imported, with some minor changes:
 - keywords set to ~x86 since I don't know if it can be build on alpha or amd64 (the isdn4k-utils version tested by arch teams was before inclusion of vbox3)
 - delete of src_compile since it is no different than default
 - better names for files/*
Comment 30 Alin Năstac (RETIRED) gentoo-dev 2004-11-21 10:54:23 UTC
raccess4box3 imported with following changes:
  - keywords: ~x86
  - description taken from home page
  - DEPEND -> RDEPEND since it does not need vbox3 to compile
Comment 31 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-21 11:18:11 UTC
ok.
Comment 32 Alin Năstac (RETIRED) gentoo-dev 2004-11-21 11:18:53 UTC
Sorry. but I'm opposing to the idea of creating 4 ebuilds for just one SRC_URI.
You must merge isdn4k-* into a single isdn4k-utils ebuild. 

capi4k-firmware: don't find useful to install only some firmware files. better block other ebuilds from installing overlapped firmwares. another veto... :(
Comment 33 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-21 12:33:06 UTC
ok, I merge it. Gimme 1 day please. Perhaps I can do it faster.
Comment 34 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-21 12:36:12 UTC
ok^2: I will remove the firmware in isdn4k-utils. But then, please rename capi4k-firmware to isdn-firmware.

I do the isdn4k-utils job, and you do the capi4k-firmware job.
Comment 35 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-21 15:10:06 UTC
Created attachment 44440 [details]
isdn4k-utils-3.5_p20041110.tar.bz2

merge of isdn4k-* + removing of all firmware files.
Comment 36 Alin Năstac (RETIRED) gentoo-dev 2004-11-22 12:30:12 UTC
isdn4k-utils-3.5_pre20041110 submitted with some minor changes.
good job, stefan!
Comment 37 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-23 03:16:50 UTC
@Alin: hmpf! you "optimized" too much. Your "minor" changes introduced a Bug. The language/country selection doesn't work anymore. :-(

The code in src_setup() *must* run before anything else!

Best place is in src_unpack() after this:

   unpack ${A}
   cd ${S}

The I4L_* variables are only used there and nowhere else. I need them to setup the config-file correctly.
Comment 38 Alin Năstac (RETIRED) gentoo-dev 2004-11-23 03:37:41 UTC
my mistake.
pls rename function src_setup to pkg_setup and see if it works.
Comment 39 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-23 03:41:23 UTC
ok, gimme a few minutes
Comment 40 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-23 03:47:20 UTC
ok, as pkg_setup() it seems to work

at least an "einfo $I4L_CC $I4L_CC_LOW $I4L_LANG" placed after "cd ${S}" in src_unpack() gives me correct results. So it should work...

and yes, it works. :-)
Comment 41 Alin Năstac (RETIRED) gentoo-dev 2004-11-23 22:38:11 UTC
I've corrected isdn4k-utils and submitted the remaining ebuilds.
good job, stefan.
Comment 42 Stefan Briesenick (RETIRED) gentoo-dev 2004-11-24 01:50:33 UTC
thanks! :-)