Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 71840 - matroska demuxer in xine-lib_rc7 do not handle A_AC3 sound
Summary: matroska demuxer in xine-lib_rc7 do not handle A_AC3 sound
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Chris White (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-20 06:33 UTC by Sergey Okhapkin
Modified: 2005-01-27 16:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Okhapkin 2004-11-20 06:33:52 UTC
Support for A_AC3 sound is missed in matroska demuxer. The following patch fixes the problem:

RCS file: /cvsroot/xine/xine-lib/src/demuxers/demux_matroska.c,v
retrieving revision 1.31
diff -u -p -r1.31 demux_matroska.c
--- demux_matroska.c    17 Sep 2004 19:21:34 -0000      1.31
+++ demux_matroska.c    20 Nov 2004 14:18:03 -0000
@@ -1096,6 +1096,9 @@ static int parse_track_entry(demux_matro
     } else if (!strcmp(track->codec_id, MATROSKA_CODEC_ID_A_PCM_INT_LE)) {
     } else if (!strcmp(track->codec_id, MATROSKA_CODEC_ID_A_PCM_FLOAT)) {
     } else if (!strcmp(track->codec_id, MATROSKA_CODEC_ID_A_AC3)) {
+      lprintf("MATROSKA_CODEC_ID_A_AC3\n");
+      track->buf_type = BUF_AUDIO_A52;
+      init_codec = init_codec_audio;
     } else if (!strcmp(track->codec_id, MATROSKA_CODEC_ID_A_DTS)) {
     } else if (!strcmp(track->codec_id, MATROSKA_CODEC_ID_A_VORBIS)) {



Reproducible: Always
Steps to Reproduce:
1.Play matroska file with A_AC3 sound
2.
3.

Actual Results:  
No audio


I submitted the bug report to xine developers already. The fix needs to go into
gentoo xine-lib_rc7 ebuild.
Comment 1 Benoit Boissinot 2004-12-27 12:54:58 UTC
I think this can be closed since rc8 and 1.0 are both marked stable (and the patch was applied upstream).

Benoit
Comment 2 Chris White (RETIRED) gentoo-dev 2005-01-27 16:54:09 UTC
Closing then.. but bah, should have probably got to this quicker :|.