Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 717904 - net-wireless/bluez: Port patch from ::musl to include limits.h for PATH_MAX into ::gentoo
Summary: net-wireless/bluez: Port patch from ::musl to include limits.h for PATH_MAX i...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Pacho Ramos
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: missing-musl-includes
  Show dependency tree
 
Reported: 2020-04-17 14:36 UTC by Michael 'veremitz' Everitt
Modified: 2020-04-22 22:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 'veremitz' Everitt 2020-04-17 14:36:54 UTC
There is only a small patch missing to support musl-libc in the main gentoo repository, which adds an include for limits.h for constant 'PATH_MAX'.

This would allow easier maintenance of the bluez package by eliminating the copy from the overlay.


Aside, but related:
I assume that the patch referenced in https://gitweb.gentoo.org/proj/musl.git/tree/net-wireless/bluez/bluez-5.51.ebuild#n70 is now redundant after removing the systemd-m4 package from Gentoo? (I see it hasn't been applied upstream, and is missing from ::gentoo).


Thanks.
Comment 1 Pacho Ramos gentoo-dev 2020-04-22 20:47:29 UTC
If it's this patch:
https://marc.info/?l=linux-bluetooth&m=157156119320950&w=2

I upstreamed it long time ago and should be included in current versions :/
Comment 2 Michael 'veremitz' Everitt 2020-04-22 21:04:19 UTC
(In reply to Pacho Ramos from comment #1)
> If it's this patch:
> https://marc.info/?l=linux-bluetooth&m=157156119320950&w=2
> 
> I upstreamed it long time ago and should be included in current versions :/

My apologies, I see you did indeed submit it, and it was merged in 2019-10, so it should have landed in 5.52. For some reason I missed the upstream commit 2d249af381a664fd5a139ee4de6bfdf2f7c2e8cf (probably looking at the github mirror rather than git.kernel.org) which contained it.

I see that 5.54 is stable in ::gentoo, and does indeed build for me on a musl system:
>>> Source compiled.
>>> Install net-wireless/bluez-5.54 into /var/tmp/portage/net-wireless/bluez-5.54/image
>>> Completed installing net-wireless/bluez-5.54 into /var/tmp/portage/net-wireless/bluez-5.54/image

Thanks for the reply, I can axe the overlay version, and apologies for the confusion!
Comment 3 Pacho Ramos gentoo-dev 2020-04-22 22:19:18 UTC
No problem, you are welcome :)