716896 – kde-misc/basket[git] fails to compile with >=dev-libs/libgit2-1

Bug 716896 - kde-misc/basket[git] fails to compile with >=dev-libs/libgit2-1

Summary: kde-misc/basket[git] fails to compile with >=dev-libs/libgit2-1

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo KDE team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2020-04-10 09:01 UTC by Dan Goodliffe
Modified:	2020-04-10 14:02 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Proposed patch (basket-2.49b-libgit2-0.99-compat.patch,1.06 KB, patch) 2020-04-10 09:06 UTC, Dan Goodliffe	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dan Goodliffe 2020-04-10 09:01:42 UTC

Basically #710832 reoccurred because the version check didn't account for a v1 major and minor going back to 0.

Reproducible: Always

Steps to Reproduce:
1. emerge basket
2.
3.



I have an amended patch which addresses this again.

Comment 1 Dan Goodliffe 2020-04-10 09:06:21 UTC

Created attachment 631854 [details, diff]
Proposed patch

This should be a drop-in replacement for existing patch in tree.

Comment 2 Andreas Sturmlechner gentoo-dev

2020-04-10 13:59:32 UTC

Thanks, will use upstream patches instead.

Comment 3 Andreas Sturmlechner gentoo-dev

2020-04-10 14:02:17 UTC

Fixed in commit 0c88696b352a14d98f1fa625e8a5e11b6674aa7d.