A new major release of ntopng is available on github. Reproducible: Always
Created attachment 634240 [details] ntopng-4.0 ebuild
Created attachment 634242 [details, diff] gmake patch
Created attachment 634244 [details, diff] mysql makefile patch
Created attachment 634246 [details, diff] ntopng-4.0-ndpi-includes.patch
src/Flow.cpp: In member function ‘void Flow::dissectNetBIOS(u_int8_t*, u_int16_t)’: src/Flow.cpp:3515:71: error: invalid conversion from ‘int’ to ‘char*’ [-fpermissive] 3515 | && (ndpi_netbios_name_interpret((char*)&payload[12], payload_len - 12, name, sizeof(name)) > 0) | ~~~~~~~~~~~~^~~~ | | | int src/Flow.cpp:3515:77: error: invalid conversion from ‘char*’ to ‘u_int’ {aka ‘unsigned int’} [-fpermissive] 3515 | && (ndpi_netbios_name_interpret((char*)&payload[12], payload_len - 12, name, sizeof(name)) > 0) | ^~~~ | | | char* src/Flow.cpp:3515:95: error: too many arguments to function ‘int ndpi_netbios_name_interpret(char*, char*, u_int)’ 3515 | && (ndpi_netbios_name_interpret((char*)&payload[12], payload_len - 12, name, sizeof(name)) > 0) | ^ In file included from /home/jer/portage/net-analyzer/ntopng-4.0/work/ntopng-4.0/include/ntop_includes.h:118, from src/Flow.cpp:22: /usr/include/ndpi/ndpi_main.h:135:7: note: declared here 135 | int ndpi_netbios_name_interpret(char *in, char *out, u_int out_len); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ This will probably have to wait for a (released) upstream fix for building against net-libs/nDPI-3.2.
Comment on attachment 634244 [details, diff] mysql makefile patch I don't see why that ought to be hard-coded. You should fix the test instead (and then again you would have to explain what installs mysql_config and when this test fails)
Comment on attachment 634242 [details, diff] gmake patch This appears to replace files/ntopng-3.8.1-parallel-make.patch but instead of setting GMAKE='$(MAKE)' it hard-codes it to 'make', which is bad, as the name of the original patch suggests: it stops make from running parallel make jobs.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7103a4ff70e61ce7c34cd0120b459b86bc092127 commit 7103a4ff70e61ce7c34cd0120b459b86bc092127 Author: Jeroen Roovers <jer@gentoo.org> AuthorDate: 2020-05-16 11:48:14 +0000 Commit: Jeroen Roovers <jer@gentoo.org> CommitDate: 2020-05-16 11:49:21 +0000 net-analyzer/ntopng: Version 4.0 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Bug: https://bugs.gentoo.org/show_bug.cgi?id=716350 Signed-off-by: Jeroen Roovers <jer@gentoo.org> net-analyzer/ntopng/Manifest | 1 + .../ntopng/files/ntopng-4.0-PKG_CONFIG.patch | 124 +++++++++++++++++++++ .../ntopng/files/ntopng-4.0-ndpi-includes.patch | 11 ++ net-analyzer/ntopng/ntopng-4.0.ebuild | 99 ++++++++++++++++ 4 files changed, 235 insertions(+)
