Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716094 - games-strategy/liquidwar-5.6.4-r2: build fails with new version (?) of allegro (PATCH)
Summary: games-strategy/liquidwar-5.6.4-r2: build fails with new version (?) of allegr...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL: https://bugs.debian.org/cgi-bin/bugre...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-04-04 00:06 UTC by Samuel Bauer
Modified: 2021-09-06 07:22 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
liquidwar-5.6.5.ebuild (liquidwar-5.6.5.ebuild,1.58 KB, text/plain)
2020-09-20 08:27 UTC, Khumba
Details
liquidwar-5.6.5-underlink.patch (liquidwar-5.6.5-underlink.patch,466 bytes, patch)
2020-09-20 08:28 UTC, Khumba
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bauer 2020-04-04 00:06:50 UTC
Fix it adding to src_prepare
sed -i 's/fsqrt/fixsqrt/g;s/fcos/fixcos/g;s/fsin/fixsin/' src/distor.c src/fighter.c src/palette.c

See:
https://bugs.debian.org/916037

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-17 03:06:51 UTC
It would help to have a full build.log and know which version it fails with.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-17 03:29:17 UTC
Could you clarify when it started failing (with what version of allegro), and give a log of the exact failure?
Comment 3 Samuel Bauer 2020-08-17 03:46:51 UTC
(In reply to Sam James from comment #1)
> It would help to have a full build.log and know which version it fails with.

Build error is exactly the same as in debian bug 916037:

/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: distor.o: in function `create_wave_line.constprop.0':                                                                                                                          
distor.c:(.text+0xb7): undefined reference to `fsqrt'                                                                          
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: distor.c:(.text+0xc0): undefined reference to `fsqrt'                                                                                                                          
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: distor.c:(.text+0x128): undefined reference to `fsin'                                                                                                                          
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: distor.c:(.text+0x137): undefined reference to `fcos'                                                                                                                          
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: distor.c:(.text+0x24e): undefined reference to `fcos'                                                                                                                          
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: fighter.o: in function `move_fighters':         
fighter.c:(.text+0x495): undefined reference to `fsqrt'                                                                        
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: fighter.c:(.text+0x49e): undefined reference to `fsqrt'                                                                                                                        
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: fighter.c:(.text+0x4cd): undefined reference to `fsqrt'                                                                                                                        
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: fighter.c:(.text+0x4d6): undefined reference to `fsqrt'
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: fighter.c:(.text+0x57e): undefined reference to `fsqrt'
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: fighter.o:fighter.c:(.text+0x587): more undefined references to `fsqrt' follow
collect2: error: ld returned 1 exit status

I may have to use pybugz for reporting, my web browser setup is far too restrictive (that's why I prefer copy - paste).

About exact version of allegro involving compile issue, I don't remember, but as this report opened on the 20200404, I assume a new version of allegro was marked stable some days before this report.
Comment 4 Samuel Bauer 2020-08-17 04:07:31 UTC
Issue seems from this commit:

https://github.com/gentoo/gentoo/commit/3be906b6d1bf00080db368eff9cef997604e4862

allegro-4.4.2-glibc228.patch was truncated from all AL_ALIAS

liquidwar still uses them and the submitted sed line just unaliases calls.
Comment 5 Andreas Sturmlechner gentoo-dev 2020-08-18 17:41:30 UTC
If this is already failing with 4.4.2-r2 then it certainly does not block stabilisation of 4.4.3.1.
Comment 6 Andreas Sturmlechner gentoo-dev 2020-08-18 17:42:01 UTC
Especially since this package isn't even stable.
Comment 7 Khumba 2020-09-20 08:27:19 UTC
There was a new liquidwar-5.6.5 release last December, and it fixes this issue upstream.  Could we do a version bump please?  I'll attach the updated ebuild and underlink patch.  The overflow fix patch is not needed anymore.  (Sorry, not sure if I should create a separate issue for this.)

Also #676068 is a dup of this.
Comment 8 Khumba 2020-09-20 08:27:52 UTC
Created attachment 661605 [details]
liquidwar-5.6.5.ebuild
Comment 9 Khumba 2020-09-20 08:28:14 UTC
Created attachment 661608 [details, diff]
liquidwar-5.6.5-underlink.patch
Comment 10 Khumba 2021-09-06 07:22:58 UTC
This bug (and #676068) are fixed now that liquidwar-5.6.5 is in the main tree.