Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 714050 - net-print/cups-filters-1.25.11: utils/cups-browsed.c:6219:52: error: expected ';' before 'strcpy'
Summary: net-print/cups-filters-1.25.11: utils/cups-browsed.c:6219:52: error: expected...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Printing Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-03-23 08:17 UTC by Thiago Nunes
Modified: 2020-03-28 07:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info net-print/cups-filters (e-info_cups-filters,6.84 KB, text/plain)
2020-03-28 07:42 UTC, Thiago Nunes
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Nunes 2020-03-23 08:17:34 UTC
Error in compile phase:

utils/cups-browsed.c:6219:52: error: expected ';' before 'strcpy'                                                                                                                              
 6219 |       cupsArrayFind(pdl_list, "application/x-pcl"))                                                                                                                                    
      |                                                    ^                                                                                                                                   
      |                                                    ;                                                                                                                                   
 6220 |               strcpy(document_format,"pcl");
      |               ~~~~~~                                 

Solution: put the missing ';' in the line 6219.


After:

cups-browsed.c:(.text+0xbf78): undefined reference to `stcpy'

# grep -n stcpy cups-browsed.c
6217:     stcpy(document_format,"pclxl");

Solution: simply correct the function's name.


So cups-filters finally compiles correctly.


Also all other ~amd64 versions 1.2[567]* and 9999:

cupsfilters/ppdgenerator.c: In function 'ppdCreateFromIPP2':
cupsfilters/ppdgenerator.c:3401:13: error: 'IPP_FINISHINGS_FOLD_ENGINEERING_Z' undeclared (first use in this function); did you mean 'IPP_FINISHINGS_FOLD_POSTER'?
 3401 |    value <= IPP_FINISHINGS_FOLD_ENGINEERING_Z)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |             IPP_FINISHINGS_FOLD_POSTER
cupsfilters/ppdgenerator.c:3401:13: note: each undeclared identifier is reported only once for each function it appears in
cupsfilters/ppdgenerator.c:3501:13: error: 'IPP_FINISHINGS_PUNCH_MULTIPLE_BOTTOM' undeclared (first use in this function); did you mean 'IPP_FINISHINGS_PUNCH_TRIPLE_BOTTOM'?
 3501 |    value <= IPP_FINISHINGS_PUNCH_MULTIPLE_BOTTOM)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |             IPP_FINISHINGS_PUNCH_TRIPLE_BOTTOM
Comment 1 Jonas Stein gentoo-dev 2020-03-23 17:39:52 UTC
I think it is fixed in the more recent versions upstream.
https://github.com/OpenPrinting/cups-filters/blob/master/utils/cups-browsed.c

Please test the other ebuilds and report.
Please paste the emerge info as described on 
https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
Comment 2 Thiago Nunes 2020-03-28 07:39:22 UTC
Strangely cups-filters-1.25.11 now compiles well and the problematic line has moved from 6219 to 6355.

However original file manually downloaded from server still has the problematic line.

Something that I don't understand has been done on gentoo's ebuild.

cups-9999 has the same behaviour.

So for me the problema is solved. 

Thanks.
Comment 3 Thiago Nunes 2020-03-28 07:42:29 UTC
Created attachment 626486 [details]
emerge --info net-print/cups-filters