Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 713526 - No more qa notice for LDFLAGS
Summary: No more qa notice for LDFLAGS
Status: RESOLVED INVALID
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Interface (emerge) (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-19 19:24 UTC by Agostino Sarubbo
Modified: 2020-03-19 20:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-03-19 19:24:23 UTC
app-text/ansifilter-2.16 does not respect LDFLAGS (I didn't see them on the link line) but there are no QA notices about that:

x86_64-pc-linux-gnu-g++   arg_parser.o stringtools.o cmdlineoptions.o main.o platform_fs.o codegenerator.o htmlgenerator.o pangogenerator.o texgenerator.o latexgenerator.o rtfgenerator.o svggenerator.o plaintextgenerator.o bbcodegenerator.o elementstyle.o stylecolour.o -o ansifilter
make[1]: Leaving directory '/var/tmp/portage/app-text/ansifilter-2.16/work/ansifilter-2.16/src'
>>> Source compiled.
>>> Test phase [not enabled]: app-text/ansifilter-2.16

>>> Install app-text/ansifilter-2.16 into /var/tmp/portage/app-text/ansifilter-2.16/image
gzip: man/ansifilter.1.gz: No such file or directory
>>> Completed installing app-text/ansifilter-2.16 into /var/tmp/portage/app-text/ansifilter-2.16/image

 * Final size of build directory: 16224 KiB (15.8 MiB)
 * Final size of installed tree:   5036 KiB ( 4.9 MiB)

strip: x86_64-pc-linux-gnu-strip --strip-unneeded -N __gentoo_check_ldflags__ -R .comment -R .GCC.command.line -R .note.gnu.gold-version
   /usr/bin/ansifilter

>>> Installing (1 of 1) app-text/ansifilter-2.16::gentoo
 * checking 4 files for package collisions
>>> Merging app-text/ansifilter-2.16 to /
--- /usr/
Comment 1 Arfrever Frehtes Taifersar Arahesis 2020-03-19 19:35:53 UTC
Detection works for me:

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/ansifilter


You most likely forgot to add -Wl,--defsym=__gentoo_check_ldflags__=0 to LDFLAGS.
Comment 2 Agostino Sarubbo gentoo-dev 2020-03-19 19:44:08 UTC
You are right...however I remember that the behavior in the past was different.

The main issue here, I guess, is that nobody communicate to do this change to the arch teams, or at least I missed that.
Comment 3 Mike Gilbert gentoo-dev 2020-03-19 20:06:43 UTC
(In reply to Agostino Sarubbo from comment #2)

It was documented as a bug fix in the release notes for portage-2.3.12. I highly recommend reading the release notes periodically.
Comment 4 Arfrever Frehtes Taifersar Arahesis 2020-03-19 20:13:10 UTC
(In reply to Agostino Sarubbo from comment #2)
> The main issue here, I guess, is that nobody communicate to do this change
> to the arch teams, or at least I missed that.

Although not all architectures, but AMD64 and X86 teams were notified in bug #680828...