Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 71223 - Samba 3.0.8 breaks all printing from Windows 98
Summary: Samba 3.0.8 breaks all printing from Windows 98
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
: 72669 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-14 17:05 UTC by Vadigo
Modified: 2004-11-28 08:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vadigo 2004-11-14 17:05:05 UTC
Small panic here as we've just put samba 3.0.8 up to fix the DoS  attack but all printing from Windows 98 has now broken.  Printing from  Windows XP is still working fine.

Reproducible: Always
Steps to Reproduce:




This path fix it:
Index: smbd/lanman.c
===================================================================
--- smbd/lanman.c	(revision 3681)
+++ smbd/lanman.c	(working copy)
@@ -2267,6 +2267,12 @@
 		return False;
 	*rparam_len = 4;
 	*rparam = REALLOC(*rparam,*rparam_len);
+
+	if ( (snum = lp_servicenumber(sharename)) == -1 ) {
+		DEBUG(0,("api_PrintJobInfo: unable to get service number from sharename [%s]\n",
+			sharename));
+		return False;
+	}
   
 	*rdata_len = 0;
Comment 1 Christian Andreetta (RETIRED) gentoo-dev 2004-11-15 01:42:21 UTC
Please post not only the patches, but the original reference also. Else, we can't accept it without proper testing.
After some time-consuming searches, I found this upstream revision: http://websvn.samba.org/cgi-bin/viewcvs.cgi?makepatch=1&rev=3682&view=rev.
Since it's the same as yours, it is accepted. :-)
Thanks for the info: samba-3.0.8-r1
Comment 2 Christian Andreetta (RETIRED) gentoo-dev 2004-11-28 08:19:45 UTC
*** Bug 72669 has been marked as a duplicate of this bug. ***