Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710922 - dev-util/pkgcheck: report multilib-minimal not inherited last
Summary: dev-util/pkgcheck: report multilib-minimal not inherited last
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-26 22:20 UTC by Alessandro Barbieri
Modified: 2020-12-20 00:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Barbieri 2020-02-26 22:20:35 UTC
from https://devmanual.gentoo.org/eclass-reference/multilib-minimal.eclass/index.html it says: "multilib-minimal should _always_ go last in inherit order!"
is it possible to get a pkgcheck warning about this?
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-01 18:59:29 UTC
I don't think that's a good idea.

Firstly, this suggestion is kinda silly.  Surely most developers know how phase function exports work, and they have the right to decide on the correct order.  Making a lot of warnings and asking people to meaninglessly change inherit order is not a good idea.

Secondly, a dozen other eclasses could make similar claims.  The moment we start reporting this for two eclasses, we're open to impossible case where developer is asked to have two eclasses last, and can't get rid of the warning.

Thirdly, there's another dozen eclasses that do not export phase functions and are entirely fine to be inherited after multilib-minimal.

So no, I don't think a warning makes sense here.
Comment 2 Tim Harder gentoo-dev 2020-12-20 00:53:47 UTC
Closing as won't fix since I agree this isn't a great target to check for. Also, ideas for pkgcheck should be filed upstream on github unless you want to assign them as ideas to the QA team for discussion otherwise I generally won't see them.