Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708864 - sys-fs/gfs2-utils-3.2.0 ebuild
Summary: sys-fs/gfs2-utils-3.2.0 ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-09 17:54 UTC by Andrea Postiglione
Modified: 2020-11-29 20:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
gfs2-utils-3.2.0 ebuild (gfs2-utils.tar.xz,4.41 KB, application/x-xz)
2020-02-09 17:54 UTC, Andrea Postiglione 		Details
gfs2-utils-3.2.0 ebuild correct (gfs2-utils.tar.xz,4.67 KB, application/x-xz)
2020-02-10 11:43 UTC, Andrea Postiglione 		Details
sys-fs/gfs2-utils-3.2.0 ebuild (gfs2-utils.tar.xz,4.45 KB, application/x-xz)
2020-02-10 13:26 UTC, Andrea Postiglione 		Details
sys-fs/gfs2-utils-3.2.0 ebuild (gfs2-utils.tar.xz,4.79 KB, application/x-xz)
2020-02-10 14:30 UTC, Andrea Postiglione 		Details
sys-fs/gfs2-utils-3.2.0 ebuild (gfs2-utils.tar.xz,4.77 KB, application/x-xz)
2020-02-13 11:58 UTC, Andrea Postiglione 		Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Postiglione 2020-02-09 17:54:30 UTC 
Created attachment 613104 [details]
gfs2-utils-3.2.0 ebuild

gfs2-utils 3.2.0 ebuild tested
Comment 1 Andrea Postiglione 2020-02-09 20:06:42 UTC 
(In reply to Andrea Postiglione from comment #0)
> Created attachment 613104 [details]
> gfs2-utils-3.2.0 ebuild
> 
> gfs2-utils 3.2.0 ebuild tested

https://sourceware.org/cluster/gfs/
https://releases.pagure.org/gfs2-utils/
Comment 2 Jonas Stein gentoo-dev 2020-02-09 21:04:26 UTC 
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman
* please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)
* We usually sort the KEYWORDS as ekeywords does. This makes comparison between packages easier. Simply run ekeywords on the ebuild to let it sort.
* A bot can look for additional mistakes, if you upload a PR via github
Comment 3 Andrea Postiglione 2020-02-10 11:43:54 UTC 
Created attachment 613176 [details]
gfs2-utils-3.2.0 ebuild correct

ebuild
Comment 4 Andrea Postiglione 2020-02-10 11:45:00 UTC 
(In reply to Andrea Postiglione from comment #3)
> Created attachment 613176 [details]
> gfs2-utils-3.2.0 ebuild correct
> 
> ebuild

repoman output

RepoMan scours the neighborhood...
  ebuild.minorsyn               22
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 19: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 20: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 24: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 25: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 26: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 27: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 28: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 29: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 30: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 33: Unquoted Variable
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 33: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 34: Unquoted Variable
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 34: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 35: Unquoted Variable
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 35: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 36: Unquoted Variable
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 36: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 37: Unquoted Variable
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 37: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 38: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 39: Ebuild contains leading spaces
   sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 40: Ebuild contains leading spaces
RepoMan sez: "You're only giving me a partial QA payment?
              I'll take it this time, but I'm not happy."
Comment 5 Andrea Postiglione 2020-02-10 11:47:00 UTC 
(In reply to Andrea Postiglione from comment #4)
> (In reply to Andrea Postiglione from comment #3)
> > Created attachment 613176 [details]
> > gfs2-utils-3.2.0 ebuild correct
> > 
> > ebuild
> 
> repoman output
> 
> RepoMan scours the neighborhood...
>   ebuild.minorsyn               22
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 19: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 20: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 24: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 25: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 26: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 27: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 28: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 29: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 30: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 33: Unquoted Variable
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 33: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 34: Unquoted Variable
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 34: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 35: Unquoted Variable
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 35: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 36: Unquoted Variable
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 36: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 37: Unquoted Variable
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 37: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 38: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 39: Ebuild contains
> leading spaces
>    sys-fs/gfs2-utils/gfs2-utils-3.2.0.ebuild: line 40: Ebuild contains
> leading spaces
> RepoMan sez: "You're only giving me a partial QA payment?
>               I'll take it this time, but I'm not happy."

I attach the correct ebuild I put amd64 as keywords as I have no way to test it on other architectures.
Comment 6 Andrea Postiglione 2020-02-10 13:26:31 UTC 
Created attachment 613180 [details]
sys-fs/gfs2-utils-3.2.0 ebuild

repoman approved!
Comment 7 Andrea Postiglione 2020-02-10 14:30:50 UTC 
Created attachment 613182 [details]
sys-fs/gfs2-utils-3.2.0 ebuild

added a patch for udev rules files
Comment 8 Andrea Postiglione 2020-02-13 11:58:11 UTC 
Created attachment 613610 [details]
sys-fs/gfs2-utils-3.2.0 ebuild
Comment 9 Andrea Postiglione 2020-11-29 20:24:48 UTC 
added to guru project!