Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708212 - media-sound/ncmpcpp duplicates tags when editing
Summary: media-sound/ncmpcpp duplicates tags when editing
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-04 12:21 UTC by Wolfgang Müller
Modified: 2021-01-10 23:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Müller 2020-02-04 12:21:57 UTC
Current stable versions of ncmpcpp with taglib duplicate existing tags when writing changes to files in the tag editor.

This has been reported upstream in https://github.com/arybczak/ncmpcpp/issues/371 and fixed with https://github.com/arybczak/ncmpcpp/pull/373

Since a new release containing this fix is not yet forthcoming, the ebuilds should be updated with a patch.

Reproducible: Always

Steps to Reproduce:
1. Build ncmpcpp with taglib
2. Open a music file in the in-built editor
3. Make some changes such that tags will be re-written to the files
4. Save changes
Actual Results:  
Tags are duplicated in the music file

Expected Results:  
Tags are not duplicated, and changes are saved normally
Comment 1 luxemboye 2021-01-10 23:08:52 UTC
The bug is still present [1,2] and hasn't been resolved for the the stable
Gentoo package (0.8.2-r1 for AMD64 & x86). Upstream [3] has since then
released new versions (0.9 & 0.91 [4]) that are still masked for Gentoo.

Wolf's patch [5] was merged [6] into upstream and is now in 0.9 and newer,
but nothing has changed for the stable gentoo package (0.8.2).

To fix the bug on stable AMD64 and x86, it requires the user to manually add
the patch [5] to their user patches. Otherwise they have to unmask a newer
version (e.g. 0.9.1). (Assumption, I haven't tried the second solution out)

P.S. I was going to attach the patch, but due to compliance with GLEP 76,
only a link to the commit and patch is included [5,6]. The patch has
been merged into upstream and the project is under GPLv2 [7].

[1] I have the issue on my updated system with the stable 0.8.2 version
    and taglib 1.11.1_p20190920-r1. Wolf's patch [5] fixed it.
[2] User with the latest taglib (stable) package (1.11.1_p20190920-r1), but
    with a 0.9_dev version (the package version used is unknown, but it is
    newer than Gentoo's stable 0.8.2):
    https://github.com/ncmpcpp/ncmpcpp/issues/371#issuecomment-610435956
[3] https://github.com/ncmpcpp/ncmpcpp
[4] https://github.com/ncmpcpp/ncmpcpp/releases
[5] https://github.com/ncmpcpp/ncmpcpp/commit/5e54cf2ca3e18de05df82bb0cd00292e8924ce24.patch
[6] https://github.com/ncmpcpp/ncmpcpp/pull/373/commits/5e54cf2ca3e18de05df82bb0cd00292e8924ce24
[7] https://github.com/ncmpcpp/ncmpcpp/blob/master/COPYING
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-01-10 23:13:40 UTC
For what it’s worth, it’s completely valid to ask for a newer stable version.