Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708182 - perl-module.eclass false-errors on missing dev-perl/Module-Build on EAPI7
Summary: perl-module.eclass false-errors on missing dev-perl/Module-Build on EAPI7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: perl-eclass
  Show dependency tree
 
Reported: 2020-02-04 03:51 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2021-04-26 17:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2020-02-04 03:51:29 UTC
In EAPI7, its preferable to put dev-perl/Module-Build in BDEPEND.

However, the check presently only checks DEPEND, so the eclass fails
unless you hack it into DEPEND too.

 * Using Module::Build
 * QA Notice: The ebuild uses Module::Build but doesn't depend on it.
 * ERROR: dev-perl/MaxMind-DB-Reader-XS-1.0.8::local-portage failed (configure phase):
 *    Add dev-perl/Module-Build to DEPEND!
 * 

Current logic is:

> einfo "Using Module::Build"
> if [[ ${DEPEND} != *virtual/perl-Module-Build* && ${DEPEND} != *dev-perl/Module-Build* && ${PN} != Module-Build ]] ; then
>     eerror "QA Notice: The ebuild uses Module::Build but doesn't depend on it."
>     die    " Add dev-perl/Module-Build to DEPEND!"
> fi
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-02-04 09:02:44 UTC
Don't forget that per PMS those vars can have totally random values.

Do you need us to patch Portage to make you realize that?
Comment 2 Andreas K. Hüttel archtester gentoo-dev 2021-04-26 17:14:08 UTC
Logic has been fixed to check BDEPEND.