Currently the devmanual has in its header: 1. Gentoo site header 2. Navigation bar with a "Home" button, a dropdown list, previous and next section buttons 3. Search box 4. List of all parents up to the document root This takes a lot of vertical space. Also, the "Home" button is redundant to both the "Back to the homepage" link above and the "Master Index" link below, so it isn't very useful. So, what would you think about combining 2 and 3 into a single navigation bar? I have some proof of concept code already working, see attached screenshots.
Created attachment 608392 [details] Current header
Created attachment 608394 [details] Suggested change This removes the redundant "Home" button, to make space for the search field in the same row.
(In reply to Ulrich Müller from comment #2) > Created attachment 608394 [details] > Suggested change > > This removes the redundant "Home" button, to make space for the search field > in the same row. How would this look on mobile? As is, the search box would disappear and not be usable, unless we add a hidden medium box as well. You can use the responsive view in most browser devtools to check.
(In reply to Brian Evans from comment #3) > How would this look on mobile? As is, the search box would disappear and > not be usable, unless we add a hidden medium box as well. You can use the > responsive view in most browser devtools to check. Good point. AFAICS, the search box disappears at the same width, regardless if it's in the same navbar, or in its own row. And you can get it back (in both cases) by pressing the toggle-navbar button at the right hand side.
(In reply to Ulrich Müller from comment #4) > (In reply to Brian Evans from comment #3) > > How would this look on mobile? As is, the search box would disappear and > > not be usable, unless we add a hidden medium box as well. You can use the > > responsive view in most browser devtools to check. > > Good point. AFAICS, the search box disappears at the same width, regardless > if it's in the same navbar, or in its own row. And you can get it back (in > both cases) by pressing the toggle-navbar button at the right hand side. The search bar was added poorly for mobile IMO, adding the collapse there is silly for one control. Also, the logo is not visible which I can easily fix.
Created attachment 608558 [details] Mobile fix to current layout Removed collapse on search and remove logo class to actually show the logo
Created attachment 608560 [details, diff] devbook.xsl: Include the search box in the navbar above. Here's what I have here, i.e., what produces the layout of attachment 608394 [details]. People doing development work on mobile devices, is that really a use case for which we must optimize? (With the single navbar, the search box would still be usable, with one extra click.)
Created attachment 608562 [details] Window capture with proposed change (In reply to Ulrich Müller from comment #7) > Created attachment 608560 [details, diff] [details, diff] > devbook.xsl: Include the search box in the navbar above. > > Here's what I have here, i.e., what produces the layout of attachment 608394 [details] > [details]. > > People doing development work on mobile devices, is that really a use case > for which we must optimize? (With the single navbar, the search box would > still be usable, with one extra click.) It looks wrong to me as is. The Search bar still does the entire length if I edit in the devtools. It would need to be in the same ul to be on the same line.
(In reply to Brian Evans from comment #8) > It looks wrong to me as is. The Search bar still does the entire length if > I edit in the devtools. It would need to be in the same ul to be on the same > line. Indeed, it doesn't look right with some browsers, e.g., with Opera. Seems that Bootstrap doesn't support input groups in navbars, only forms (which is what the wiki uses).
Reopening, because I think that the following is still valid. > The "Home" button is redundant to both the "Back to the homepage" link > above and the "Master Index" link below, so it isn't very useful.
Created attachment 613086 [details, diff] devbook.xsl: Remove redundant "Home" button.
@arzano: CCing you, because we had discussed the issue at FOSDEM. Problem is that the navbar still collapses at the same width, even if it contains only three instead of four items. Is that width a hardcoded constant in the Tyrian layout?
Created attachment 615938 [details, diff] devmanual-remove-search-collapse.patch Patch to remove collapse from search bar which hides it on small devices
Comment on attachment 613086 [details, diff] devbook.xsl: Remove redundant "Home" button. (In reply to Ulrich Müller from comment #11) > Created attachment 613086 [details, diff] [details, diff] > devbook.xsl: Remove redundant "Home" button. I withdraw this one too. The home button is present on other Gentoo sites, so we should keep it as well (and it doesn't take much space).
(In reply to Brian Evans from comment #13) > Created attachment 615938 [details, diff] [details, diff] > devmanual-remove-search-collapse.patch > > Patch to remove collapse from search bar which hides it on small devices Committed: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=62bfb0e50692e56b5a6d6559e85a587a62e67789 commit 62bfb0e50692e56b5a6d6559e85a587a62e67789 Author: Ulrich Müller <ulm@gentoo.org> Date: Tue Feb 25 21:10:27 2020 +0100 devbook.xsl: Remove collapse from search bar. In order not to hide it on small devices. Patch from Brian Evans <grknight@gentoo.org> in bug 615938. Signed-off-by: Ulrich Müller <ulm@gentoo.org> Let's consider this bug as fixed.
