Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 704628 - net-irc/kvirc-9999 - obsolete kvirc-5.2_pre20190628041642-python-3.patch fails
Summary: net-irc/kvirc-9999 - obsolete kvirc-5.2_pre20190628041642-python-3.patch fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Arfrever Frehtes Taifersar Arahesis
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-03 08:04 UTC by Michael Moon
Modified: 2020-01-22 01:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kvirc-9999.ebuild with offending patch removed from PATCHES (kvirc-9999.ebuild,4.10 KB, text/plain)
2020-01-03 08:04 UTC, Michael Moon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Moon 2020-01-03 08:04:01 UTC
Created attachment 602356 [details]
kvirc-9999.ebuild with offending patch removed from PATCHES

kvirc-9999 seems to build and run just fine without the patch.

It's trivial to remove it from the ebuild, but I've attached a tweaked ebuild anyway. I didn't touch the python dependencies, they may want further munging.

#224919 has similar content but it's a decade old; so I presume the current situation warrants a fresh bug report ;)
Comment 1 Arfrever Frehtes Taifersar Arahesis 2020-01-04 04:15:52 UTC
I already created correct patch about 2 days ago, but porting to cmake.eclass remains...

(In reply to Michael Moon from comment #0)
> Created attachment 602356 [details]
> kvirc-9999.ebuild with offending patch removed from PATCHES
> 
> kvirc-9999 seems to build and run just fine without the patch.

No, because upstream migrated from FindPythonLibs.cmake to FindPython3.cmake, which automagically uses newest found Python version instead of version selected by PYTHON_SINGLE_TARGET.
So the correct ebuild will override things by passing -DPython3_INCLUDE_DIR and -DPython3_LIBRARY to cmake.
Comment 2 Arfrever Frehtes Taifersar Arahesis 2020-01-22 01:33:32 UTC
Ebuild was updated in commit 4d91171b612acd924ca814c715634d639b853f47.