Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 703880 - dev-vcs/subversion - USE=plaintext-password-storage: add optional support for plain text password storage
Summary: dev-vcs/subversion - USE=plaintext-password-storage: add optional support for...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andreas K. Hüttel
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-12-26 21:12 UTC by Chris
Modified: 2020-05-27 18:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris 2019-12-26 21:12:09 UTC
Starting in subversion v1.12.0, the devs changed the default behavior to disable plain text password storage; from the CHANGELOG:
    * Storing passwords in plain text on disk is disabled by default (r1845377)

A use flag can be implemented to re-enable this named plaintext-password-storage followed with a $(use_enable plaintext-password-storage) directive in src_configure.

For example:
--- /usr/portage/dev-vcs/subversion/subversion-1.13.0.ebuild	2019-12-20 10:09:38.000000000 -0500
+++ subversion-1.13.0-r1.ebuild	2019-12-26 15:57:08.299955394 -0500
@@ -22,7 +22,7 @@
 SLOT="0"
 [[ "${PV}" = *_rc* ]] || \
 KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~ppc ~ppc64 ~sparc ~x86 ~amd64-linux ~x86-linux"
-IUSE="apache2 berkdb ctypes-python debug doc +dso extras gnome-keyring +http java kwallet nls perl python ruby sasl test vim-syntax"
+IUSE="apache2 berkdb ctypes-python debug doc +dso extras gnome-keyring +http java kwallet nls perl python ruby sasl test vim-syntax +plaintext-password-storage"
 RESTRICT="!test? ( test )"
 
 COMMON_DEPEND="
@@ -204,6 +204,7 @@
 		--disable-mod-activation
 		--disable-static
 		--enable-svnxx
+		$(use_enable plaintext-password-storage)
 	)
 
 	if use python || use perl || use ruby; then
Comment 1 Andreas K. Hüttel archtester gentoo-dev 2020-05-12 19:16:35 UTC
Nope.
Comment 2 Chris 2020-05-12 23:25:33 UTC
Why? Put the control in the user's hands. This is useful for automating pulls from non-user systems. As package maintainer, why do you have final say on what the user chooses when the option is available in the package? This does not feel very Gentoo-like.
Comment 3 slavko glamocanin 2020-05-26 21:10:11 UTC
It would appease the gentoo gods of choice and excessive use flags if you added this patch so i don't have to do it manually every time. Thanks!
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-05-26 21:47:09 UTC
(In reply to slavko glamocanin from comment #3)
> It would appease the gentoo gods of choice and excessive use flags if you
> added this patch so i don't have to do it manually every time. Thanks!

I think EXTRA_ECONF in package.env would do the job for you.
Comment 5 Chris 2020-05-27 00:14:40 UTC
(In reply to Sam James (sec padawan) from comment #4)
> (In reply to slavko glamocanin from comment #3)
> > It would appease the gentoo gods of choice and excessive use flags if you
> > added this patch so i don't have to do it manually every time. Thanks!
> 
> I think EXTRA_ECONF in package.env would do the job for you.

This requires econf be called with ${EXTRA_ECONF[@]}, which is not in the current ebuild. It is required for that to work, correct? This ebuild should be updated to have the additional USE flag OR to leverage the EXTRA_ECONF environment variable(s). Not sure why this simple adjustment is being dismissed?
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-05-27 01:25:53 UTC
(In reply to Chris from comment #5)
> (In reply to Sam James (sec padawan) from comment #4)
> > (In reply to slavko glamocanin from comment #3)
> > > It would appease the gentoo gods of choice and excessive use flags if you
> > > added this patch so i don't have to do it manually every time. Thanks!
> > 
> > I think EXTRA_ECONF in package.env would do the job for you.
> 
> This requires econf be called with ${EXTRA_ECONF[@]}, which is not in the
> current ebuild. It is required for that to work, correct? This ebuild should
> be updated to have the additional USE flag OR to leverage the EXTRA_ECONF
> environment variable(s). Not sure why this simple adjustment is being
> dismissed?

As far as I understand, this happens by default when `econf` is used: https://github.com/gentoo/portage/blob/42fe7eadad8c80836ace0de527e988383f63b7da/bin/phase-helpers.sh#L669.

There's usually some reluctance to add USE flags for a simple feature if there's already quite a few, because it makes it hard to test, but I am not the maintainer.

Can you give this a go and let me know what happens?
Comment 7 Chris 2020-05-27 14:27:32 UTC
(In reply to Sam James (sec padawan) from comment #6)
> (In reply to Chris from comment #5)
> > (In reply to Sam James (sec padawan) from comment #4)
> > > (In reply to slavko glamocanin from comment #3)
> > > > It would appease the gentoo gods of choice and excessive use flags if you
> > > > added this patch so i don't have to do it manually every time. Thanks!
> > > 
> > > I think EXTRA_ECONF in package.env would do the job for you.
> > 
> > This requires econf be called with ${EXTRA_ECONF[@]}, which is not in the
> > current ebuild. It is required for that to work, correct? This ebuild should
> > be updated to have the additional USE flag OR to leverage the EXTRA_ECONF
> > environment variable(s). Not sure why this simple adjustment is being
> > dismissed?
> 
> As far as I understand, this happens by default when `econf` is used:
> https://github.com/gentoo/portage/blob/
> 42fe7eadad8c80836ace0de527e988383f63b7da/bin/phase-helpers.sh#L669.
> 
> There's usually some reluctance to add USE flags for a simple feature if
> there's already quite a few, because it makes it hard to test, but I am not
> the maintainer.
> 
> Can you give this a go and let me know what happens?

This does work and is a good workaround to this stance on updating the ebuild (which I still contend is not all that challenging for this package AND has received no real feedback as to why "nope" is an acceptable package maintainer response to such a request).

For slavko, as I had not used EXTRA_ECONF before and it took a moment to learn the syntax:
# cat /etc/portage/env/subversion.conf 
EXTRA_ECONF="--enable-plaintext-password-storage"
# cat /etc/portage/package.env/subversion 
dev-vcs/subversion	subversion.conf