Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 703812 - net-p2p/amule: Fix build with libupnp 1.8 and later
Summary: net-p2p/amule: Fix build with libupnp 1.8 and later
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexander Tsoy
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-12-26 09:02 UTC by Hanno Böck
Modified: 2020-01-17 13:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2019-12-26 09:02:59 UTC 
In a current ~amd64 system amule fails to build, as the code is not compatible with libupnp 1.8 or 1.10.

Here's the upstream patch:
https://github.com/amule-project/amule/commit/f6dccde218fed8dabd3c61efce02d29b320858fe#diff-4169b723de8fba9b3f57f82e93a3a5bb.diff

Note there's a followup patch making it build again with old libupnp (1.6):
https://github.com/amule-project/amule/commit/cb30875bd4e45736ff4ee1137ff97316295ff7be#diff-4169b723de8fba9b3f57f82e93a3a5bb

Given that 1.6.x is still the stable version in gentoo we may want to apply both to be compatible with both versions.
Comment 1 Andreas Sturmlechner gentoo-dev 2019-12-26 09:06:25 UTC 
There's a PR, but it currently breaks CI.
Comment 2 Alexander Tsoy 2019-12-26 09:13:03 UTC 
Yeah, I need to migrate to acct-group/acct-user. And I want to change the user from p2p to amule in the process.
Comment 3 Ștefan Talpalaru 2020-01-05 16:37:34 UTC 
A working amule-2.3.2_p20191216 is available in my overlay: https://github.com/stefantalpalaru/gentoo-overlay