Bug 70225 – sandbox_pids_file code in sandbox needs love.

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Mr. Bones. (RETIRED) 2004-11-06 01:05:51 UTC]

sandbox_pids_file isn't initialized so if get_sandbox_pids_file() returns a string
that's >=254 sandbox_pids_file might not be null terminated.

        char sandbox_pids_file[255];

        tmp_string = get_sandbox_pids_file();
        strncpy(sandbox_pids_file, tmp_string, sizeof(sandbox_pids_file)-1);

later on in the file:

                tmp_string = get_sandbox_pids_file();
                strncpy(sandbox_pids_file, tmp_string, 254);

The magic constant is a disaster waiting to happen.

Both cases probably should just use the pointer from get_sandbox_pids_file() directly and just free it when they're done instead of putting it into a static array.

[Comment 1 Brian Harring (RETIRED) 2004-11-14 22:27:57 UTC]

in portage cvs atm, please test.

[Comment 2 Brian Harring (RETIRED) 2005-03-08 23:41:25 UTC]

Went out a while back...