Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 70170 - ignorecvs filtering buggy in portage.py
Summary: ignorecvs filtering buggy in portage.py
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: High minor (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2004-11-05 08:17 UTC by Ludovic Aubry
Modified: 2005-07-14 06:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fixes the bug, and function cleanup (listdir.patch,1.90 KB, patch)
2004-11-05 08:21 UTC, Ludovic Aubry
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ludovic Aubry 2004-11-05 08:17:47 UTC
the test :
not (ignorecvs and (len(list[x])>=3) and (("/"+list[x][-3:])=="/CVS"))
in portage.py:322 is buggy and will prevent all dirs ending in CVS to be scanned by listdir when the ignorecvs flag is true

fix is to replace the test by:
ignorecvs and os.path.basename(list[x])=="CVS"
The same considerations apply for the next test against ".svn"
Comment 1 Ludovic Aubry 2004-11-05 08:21:13 UTC
Created attachment 43349 [details, diff]
fixes the bug, and function cleanup

Here is a proposed patch that also cleans up the function: it should be faster
and more readable

the patch has been tested on a basic installation with
emerge info
emerge sync
emerge world
Comment 2 Jason Stubbs (RETIRED) gentoo-dev 2005-07-14 05:48:03 UTC
Fixed on or before 2.0.51.22-r1 
Comment 3 Jason Stubbs (RETIRED) gentoo-dev 2005-07-14 06:58:45 UTC
Looking through the batch of bugs, I'm not sure that some of these are 
actually fixed in stable. Others, the requirements have possibly changed after 
the initial fix was committed. 
 
If you think this bug has been closed incorrectly, please reopen or ask that 
it be reopened.