Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 700962 - app-portage/repoman: COMMIT_EDITMSG is created in /tmp
Summary: app-portage/repoman: COMMIT_EDITMSG is created in /tmp
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-23 01:58 UTC by tastytea
Modified: 2022-07-12 03:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tastytea 2019-11-23 01:58:48 UTC
I'd like to use `git-commit-signoff` from Magit (an Emacs frontend for git) to add a “Signed-off-by:”-line to the commit. This command uses the git settings user.name and user.email. The problem is, that the global values are used, not the local (in .git/config) ones. I believe it is because repoman creates COMMIT_EDITMSG inside /tmp¹ but git creates it in .git (or $GIT_DIR). Is there a reason why it is put in /tmp? Can we change it to .git?


¹ <https://github.com/gentoo/portage/blob/0d7aa0d4991f402c2ff7c386419e177a5244c9a0/repoman/lib/repoman/actions.py#L584>

Reproducible: Always

Steps to Reproduce:
1. cd to a Gentoo repository with git
2. git config --local user.email test@example.invalid
3. Make a change and git add it
4. EDITOR=emacs repoman commit
5. (In Emacs) git-commit-signoff
Actual Results:  
The global values for user.name and user.email are used.

Expected Results:  
The local values for user.name and user.email are used.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:27 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.