Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 6982 - id3lib 3.8.0 has less than graceful gcc check
Summary: id3lib 3.8.0 has less than graceful gcc check
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High trivial (vote)
Assignee: Matthew Kennedy (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-24 11:43 UTC by Olav Kolbu
Modified: 2003-02-04 19:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olav Kolbu 2002-08-24 11:43:42 UTC
src_unpack() {

        unpack ${A}

        if [ "`gcc --version | cut -f1 -d.`" -eq 3 ] ||
           ([ -n "${CXX}" ] && [ "`${CXX} --version | cut -f1 -d.`" -eq 3 ]) ||
           [ "`gcc --version|grep gcc|cut -f1 -d.|cut -f3 -d\ `" -eq 3 ]
        then
                cd ${S}
                # Removed azarah's patch for _pre2 (doesn't seem to be
[...]

The final test line there will throw an error on gcc versions less than 3, since
there is no "gcc" in the "gcc --version" output, and thus the expression
resolves to [ "" -eq 3 ]


bash-2.05a# [ "`gcc --version|grep gcc|cut -f1 -d.|cut -f3 -d\ `" -eq 3 ]
[: : integer expression expected
bash-2.05a# gcc --version
2.95.3

Not that it actually matters, since the test is only supposed to succeed on v3,
but it should be done in a way that doesn't throw an error at the user.

                        OK
Comment 1 Matthew Kennedy (RETIRED) gentoo-dev 2002-08-26 23:53:05 UTC
olav,

i just corrected the ebuild. there will be no new -r release for this change. to
test it, just emerge rsync and emerge id3lib. it should appear on the rsync
mirrors after about 45 minutes from now.

let me know if there are any problems, and thanks for the bug report!

matt