Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 698042 - net-misc/ntpsec installs logrotate file that causes logrotate errors by default
Summary: net-misc/ntpsec installs logrotate file that causes logrotate errors by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Steve Arnold
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-19 12:55 UTC by Maciej S. Szmigiero
Modified: 2019-11-09 19:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Possible patch (file_698042.txt,309 bytes, patch)
2019-10-23 08:46 UTC, James Browning
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej S. Szmigiero 2019-10-19 12:55:10 UTC
net-misc/ntpsec installs /etc/logrotate.d/ntpd logrotate file that tries to
rotate "/var/log/ntpd.log" log file.

This log file is, however, not created by default by ntpd.
It is only referenced by /etc/ntp.d/use-performance-logging "Collect NTP
performance statistics for analysis" config snippet.
This config snippet is disabled by default.

Because /etc/logrotate.d/ntpd does not contain a "missingok" directive this results in errors every time logrotate is run:
error: stat of /var/log/ntpd.log failed: No such file or directory
2019-10-19T03:20:01 pc logrotate[1234]: ALERT exited abnormally with [1]
2019-10-19T03:20:02 pc anacron[5678]: Job `cron.daily' terminated (exit status: 1) (produced output)

Please add a "missingok" directive to this ntpd logrotate config file so it
doesn't cause errors in the default configuration.
Comment 1 James Browning 2019-10-19 20:50:09 UTC
Reported upstream https://gitlab.com/NTPsec/ntpsec/merge_requests/1039
Comment 2 James Browning 2019-10-20 07:13:24 UTC
This issue is now fixed in the next release upstream. Given my lack of recent success with patches here, I'll leave it for someone else to fix the ebuild(s).
Comment 3 Anthony Basile gentoo-dev 2019-10-20 23:06:16 UTC
(In reply to James Browning from comment #2)
> This issue is now fixed in the next release upstream. Given my lack of
> recent success with patches here, I'll leave it for someone else to fix the
> ebuild(s).

I'm not sure what you mean, but if you provide me the patch, I'll add it.
Comment 4 James Browning 2019-10-23 08:46:57 UTC
Created attachment 593686 [details, diff]
Possible patch

this might be fileable as files/ntpsec-1.1.4-log-rotation-fix.patch
Comment 5 Steve Arnold archtester gentoo-dev 2019-11-09 19:18:24 UTC
These are all fine in master (just missing-the-missing on the releases) so I added a patch to 1.1.7-r2 (along with some other minor bug fixes).