Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 697714 - www-client/firefox USE=jack fails to add jack capture ports in web pages which want a capture device
Summary: www-client/firefox USE=jack fails to add jack capture ports in web pages whic...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-10-14 17:07 UTC by Logan Perkins
Modified: 2020-03-29 23:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Logan Perkins 2019-10-14 17:07:55 UTC
www-client/firefox built with the jack use flag fails to add jack capture ports in web pages which want a capture device.  The issue is that the jack backend in libcubeb refuses to create a stream if there is already a device defined.  When adding an input stream, the output device is already defined, triggering the error return.

I've opened an issue on cubeb's tracker, but it is likely to take a while to get it resolved and merged into firefox itself.  In the meantime, a patch for building firefox is pretty simple.  

diff media/libcubeb/src/cubeb_jack.cpp.orig media/libcubeb/src/cubeb_jack.cpp
746c746
<   if (input_device || output_device)
---
>   if ((input_stream_params && input_device) || (output_stream_params && output_device))
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-10-14 21:01:35 UTC
(In reply to Logan Perkins from comment #0)
> I've opened an issue on cubeb's tracker

Please post that tracker URL.
Comment 2 Logan Perkins 2019-10-14 21:14:55 UTC
Oh, of course.
https://github.com/kinetiknz/cubeb/issues/550
Comment 3 Logan Perkins 2019-10-24 23:38:50 UTC
Alright, it's been fixed in the upstream library.  It'll take a while to get into the current firefox source, and won't ever reach the released versions of firefox.  The patch from upstream can easily be applied to existing ebuilds, and has a bit of sanity checking.  If we can apply it to the current ebuilds, it would make the jack use flag more useful for firefox.

The relevant commit is
https://github.com/kinetiknz/cubeb/pull/552/commits/5dc6a4d79c29d7cf2ecd65efb4401d860140b1cb
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2020-03-29 23:46:47 UTC
Closing as obsolete. Vanilla firefox-74 includes these changes.