Bug 6963 – kdetoys 3.1 beta fails to compile - fix included

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Brian Rozmierski 2002-08-24 00:18:38 UTC]

Fix for error: 
make[3]: Entering directory 
`/var/tmp/portage/kdetoys-3.1_beta1/work/kdetoys-3.0.7/kweather' 
i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/kde/3.1/include 
-I/usr/qt/3/include -I/usr/X11R6/include   -DQT_THREAD_SUPPORT  -D_REENTRANT  
-Wnon-virtual-dtor -Wno-long-long -Wbad-function-cast -Wundef -Wall -pedantic 
-W -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -ansi 
-D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -DNDEBUG 
-DNO_DEBUG -O2 -march=i686 -O3 -pipe -fno-exceptions -fno-check-new 
-DQT_CLEAN_NAMESPACE  -DQT_NO_ASCII_CAST  -c -o kweatherservice.all_cpp.o 
`test -f kweatherservice.all_cpp.cpp || echo './'`kweatherservice.all_cpp.cpp 
In file included from kweatherservice.all_cpp.cpp:2: 
main.cpp: In function `int main(int, char**)': 
main.cpp:35: warning: unused variable `WeatherService*service' 
In file included from /usr/include/g++-v31/backward/iostream.h:31, 
                 from weatherlib.cpp:18, 
                 from kweatherservice.all_cpp.cpp:3: 
/usr/include/g++-v31/backward/backward_warning.h:32:2: warning: #warning This 
file includes at least one deprecated or antiquated header. Please consider 
using one of the 32 headers found in section 17.4.1.2 of the C++ standard. 
Examples include substituting the <X> header for the <X.h> header for C++ 
includes, or <sstream> instead of the deprecated header <strstream.h>. To 
disable this warning use -Wno-deprecated. 
In file included from kweatherservice.all_cpp.cpp:4: 
weatherservice.cpp: In member function `bool 
WeatherService::forceUpdate(QString)': 
weatherservice.cpp:100: warning: no return statement in function returning 
non-void 
weatherservice.cpp: In member function `bool 
WeatherService::removeStation(QString)': 
weatherservice.cpp:105: warning: no return statement in function returning 
non-void 
weatherservice.cpp: In member function `bool 
WeatherService::addStation(QString)': 
weatherservice.cpp:110: warning: no return statement in function returning 
non-void 
weatherservice.cpp: In member function `int WeatherService::maxAge()': 
weatherservice.cpp:120: warning: no return statement in function returning 
non-void 
weatherservice.cpp: In member function `bool WeatherService::exit()': 
weatherservice.cpp:124: void value not ignored as it ought to be 
weatherservice.cpp: In member function `bool 
WeatherService::removeStation(QString)': 
weatherservice.cpp:103: warning: unused parameter `QString stationID' 
weatherservice.cpp: In member function `void WeatherService::setMaxAge(int)': 
weatherservice.cpp:113: warning: unused parameter `int age' 
make[3]: *** [kweatherservice.all_cpp.o] Error 1 
make[3]: Leaving directory 
`/var/tmp/portage/kdetoys-3.1_beta1/work/kdetoys-3.0.7/kweather' 
 
 
The version included in the beta tarball is NOT the version tagged in CVS as 
the 3.1 beta version. It's CVS version 1.9 -- the URL above is the diff to 
1.10 (remove return from the last function's exit call), and applying the 
change (which backs out a previous change) has gotten me past this error.

[Comment 1 Rigo 2002-08-24 05:05:32 UTC]

Created attachment 3380 [details]
files/kdetoys-3.1_beta1.diff

[Comment 2 Rigo 2002-08-24 05:06:33 UTC]

Created attachment 3381 [details]
kdetoys-3.1_beta1-r1.ebuild

[Comment 3 Dan Armak (RETIRED) 2002-08-29 15:59:44 UTC]

Thanks for looking up the fix. I'll test it here, if it compiles overnight I'll 
commit it tomorrow morning. 

[Comment 4 Dan Armak (RETIRED) 2002-08-30 02:41:30 UTC]

Committed too.