Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 69565 - epkgmove needs to regenerate Manifest after commiting the package to the new location
Summary: epkgmove needs to regenerate Manifest after commiting the package to the new ...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Ian Leitch (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-30 18:57 UTC by Sven Wegener
Modified: 2004-12-19 14:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
epkgmove-1.3.py.patch (epkgmove-1.3.py.patch,477 bytes, patch)
2004-12-19 09:54 UTC, Sven Wegener
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Wegener gentoo-dev 2004-10-30 18:57:13 UTC
epkgmove needs to regenerate the Manifest after commiting the package to the new location because the $Header: $ CVS keyword tag in ChangeLog and *.ebuild will change during commit. This breaks FEATURES="strict" as portage checks the Manifest against the files in the tree.
Comment 1 Ian Leitch (RETIRED) gentoo-dev 2004-12-18 15:42:23 UTC
Fixed in 1.2:
http://dev.gentoo.org/~port001/DevTools/epkgmove/epkgmove-1.2.py
Comment 2 Sven Wegener gentoo-dev 2004-12-18 20:08:37 UTC
Looking at epkgmove-1.2.py it seems that it only re-commits the Manifest if sign
is in FEATURES. It should always be recommited. And forcing a digest regeneration
for all ebuilds to just update the Manifest is probably wrong too. The forced
digest regeneration forces downloading of the distfiles, if the files are not yet
available in DISTDIR. The digests should not be affected by a move.
Comment 3 Ian Leitch (RETIRED) gentoo-dev 2004-12-19 07:55:48 UTC
The Manifest is re-commited when 'ebuild foo digest' is called, and commited once more if 'sign' is in features. 1.3 doesn't regen the digests when not needed. 
http://dev.gentoo.org/~port001/DevTools/epkgmove/epkgmove-1.3.py
Comment 4 Sven Wegener gentoo-dev 2004-12-19 09:54:50 UTC
Created attachment 46353 [details, diff]
epkgmove-1.3.py.patch

The Manifest re-commit should not depend on sign in FEATURES. The sign step is
optional before committing the Manifest.
Comment 5 Ian Leitch (RETIRED) gentoo-dev 2004-12-19 13:56:33 UTC
You're miss reading the code. What you are looking at is the gpg signing function which signs the Manifest if 'sign' is in FEATURES. The non-signed Manifest is regenerated and commited before this function is even called.
Comment 6 Ian Leitch (RETIRED) gentoo-dev 2004-12-19 14:03:52 UTC
Doh, I'm the one miss reading my _own_ code lol. 
Comment 7 Ian Leitch (RETIRED) gentoo-dev 2004-12-19 14:21:15 UTC
1.3.1 in the usual place