Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 695088 - net-misc/ntpsec: QA issues
Summary: net-misc/ntpsec: QA issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Steve Arnold
URL: https://qa-reports.gentoo.org/output/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-20 07:32 UTC by Michał Górny
Modified: 2019-11-09 19:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Possible patch (file_695088.txt,6.04 KB, patch)
2019-09-24 23:28 UTC, James Browning
Details | Diff
mostly unrelated patch glep-0081 (file_695088.txt,3.56 KB, patch)
2019-09-25 00:02 UTC, James Browning
Details | Diff
address stuff (0001-net-misc-ntpsec-possibly-address-issue-695088.patch,17.35 KB, patch)
2019-10-17 18:03 UTC, James Browning
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-20 07:32:43 UTC
net-misc/ntpsec
  UnderscoreInUseFlag: USE flag 'rclock_oncore' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_trimble' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_truetime' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_gpsd' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_jjy' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_generic' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_spectracom' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_shm' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_pps' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_hpgps' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_zyfer' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_arbiter' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_nmea' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_neoclock' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_modem' uses reserved underscore character
  UnderscoreInUseFlag: USE flag 'rclock_local' uses reserved underscore character
Comment 1 James Browning 2019-09-24 20:18:23 UTC
Vestigial. Intended for use with USE_EXPAND which is no longer an option here (and never really was). Repoman never complained about it. Options 1) remove flags to assumed +, 2) rename to hyphenated 3) remove prefix 4) other?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-24 20:20:20 UTC
If flags are not really useful (read: building all things comes with little cost and no dependencies), remove them.  Otherwise, strip the prefix to make flags shorter.
Comment 3 James Browning 2019-09-24 23:28:59 UTC
Created attachment 590984 [details, diff]
Possible patch

Forces building all reflocks and the required net-misc/pps-tools, removing the prohibited use flag underscores in the process.
Comment 4 James Browning 2019-09-25 00:02:25 UTC
Created attachment 590986 [details, diff]
mostly unrelated patch glep-0081
Comment 5 James Browning 2019-10-17 18:03:30 UTC
Created attachment 593004 [details, diff]
address stuff

probably obsoletes 59084
* force inclusion of refclocks without an extra dep, removing old useflags.
* add pps option for reclocks that need it, removing old useflags.
* remove heat and test useflags that did not need anything externally.
* change all ebuilds to use single build timestamp for all python versions.
* remove ntpviz useflag that only added extra runtime dependencies.
* update metadata and manifest files to reflect the above changes.
Comment 6 Steve Arnold archtester gentoo-dev 2019-11-09 19:52:59 UTC
This has been addressed in 1.1.7-r2 and 9999, however, the time server use case requires individual flags (so all or nothing is not a good fit).  For now the underscore has been swapped for a dash; feel free to open another bug if needed.