Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 694688 - sys-kernel/gentoo-sources - GENTOO_LINUX_INIT_SCRIPT should select FILE_LOCKING - Call to flock failed: Function not implemented
Summary: sys-kernel/gentoo-sources - GENTOO_LINUX_INIT_SCRIPT should select FILE_LOCKI...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard: gentoo-sources-5.3.7
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-17 13:43 UTC by Marius Stoica
Modified: 2019-10-18 13:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marius Stoica 2019-09-17 13:43:50 UTC 
When configuring gentoo-sources and selecting "OpenRC, runit and other script based systems and managers", it should enable the "POSIX file locking API". 

I compiled a kernel without this feature and when I booted it stopped at "Caching service dependencies", which was the 4th or so service that started. The error was "Call to flock failed: Function not implemented".



Reproducible: Always
Comment 1 Mike Pagano gentoo-dev 2019-09-18 17:13:52 UTC 
Did you also need : MANDATORY_FILE_LOCKING  ?
Comment 2 Mike Pagano gentoo-dev 2019-09-18 17:20:10 UTC 
Looks like systemd needs FILE_LOCKING, also.
Comment 3 Marius Stoica 2019-09-18 19:06:56 UTC 
No, I compiled without Mandatory file locking and it worked.
Comment 4 Mike Pagano gentoo-dev 2019-09-19 10:01:19 UTC 
(In reply to Marius Stoica from comment #3)
> No, I compiled without Mandatory file locking and it worked.

Thanks, yeah, there's notes about that being dead code that have since found.

I'll start adding FILE_LOCKING to the supported kernels through the next few days.
Comment 5 Mike Pagano gentoo-dev 2019-10-16 18:21:18 UTC 
5.3 slipped through the cracks, it will be in the next release
Comment 6 Mike Pagano gentoo-dev 2019-10-18 13:52:42 UTC 
commit 8207d7631e9b199343cacb8aa1a86a599e7242d9
Author: Mike Pagano <mpagano@gentoo.org>
Date:   Wed Oct 16 14:20:44 2019 -0400

    Add FILE_LOCKING to GENTOO_LINUX config. See bug #694688.
    
    Thanks to Marius Stoica for reporting
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>