Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 694364 - media-video/mpv-9999: build fails due to removed libraries in upstream
Summary: media-video/mpv-9999: build fails due to removed libraries in upstream
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-14 15:49 UTC by Esad Katmer
Modified: 2019-10-26 21:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Emerge Info (emerge--info.txt,6.48 KB, text/plain)
2019-09-14 15:52 UTC, Esad Katmer
Details
emerge --info media-video/mpv (info_mpv-9999.log,7.20 KB, text/plain)
2019-09-14 15:52 UTC, Esad Katmer
Details
build-1-dvdread.log (build-1-dvdread.log,29.83 KB, text/plain)
2019-09-14 18:07 UTC, Esad Katmer
Details
build-2-tv.log (build-2-tv.log,29.79 KB, text/plain)
2019-09-14 18:08 UTC, Esad Katmer
Details
build-3-tv-v4l2.log (build-3-tv-v4l2.log,29.76 KB, text/plain)
2019-09-14 18:08 UTC, Esad Katmer
Details
build-4-libv4l2.log (build-4-libv4l2.log,29.72 KB, text/plain)
2019-09-14 18:08 UTC, Esad Katmer
Details
build-5-audio-input.log (build-5-audio-input.log,29.69 KB, text/plain)
2019-09-14 18:09 UTC, Esad Katmer
Details
quick-and-dirty.patch (mpv-quick-and-dirty.patch,1.43 KB, patch)
2019-09-25 12:29 UTC, gerion
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Esad Katmer 2019-09-14 15:49:33 UTC
mpv authors removed classic Linux analog TV support, and DVB runtime controls and libdvdread support. Emerge fails at compiling.

Solution: remove tv and dvdread use flags

Sources:
https://github.com/mpv-player/mpv/commit/b30e85508a305d668db8419556d295a65ab08707#diff-dc6134e3d3c869a052520d86f46371dcL877
https://github.com/mpv-player/mpv/commit/ebab42c9a826e346faa89482847f442546a554f5


Reproducible: Always

Steps to Reproduce:
1. emerge -1v 'media-video/mpv-9999'
2. emerge says there is no option
Actual Results:  
waf: error: no such option: --disable-dvdread
waf: error: no such option: --disable-tv
waf: error: no such option: --disable-tv-v4l2
waf: error: no such option: --disable-libv4l2
waf: error: no such option: --disable-audio-input



Expected Results:  
>>> media-video/mpv-9999 merged.
Comment 1 Esad Katmer 2019-09-14 15:52:05 UTC
Created attachment 589818 [details]
Emerge Info
Comment 2 Esad Katmer 2019-09-14 15:52:37 UTC
Created attachment 589820 [details]
emerge --info media-video/mpv
Comment 3 Esad Katmer 2019-09-14 18:07:40 UTC
Created attachment 589822 [details]
build-1-dvdread.log

Error: waf: error: no such option: --disable-dvdread
Comment 4 Esad Katmer 2019-09-14 18:08:10 UTC
Created attachment 589824 [details]
build-2-tv.log

Error: waf: error: no such option: --disable-tv
Comment 5 Esad Katmer 2019-09-14 18:08:28 UTC
Created attachment 589826 [details]
build-3-tv-v4l2.log

Error: waf: error: no such option: --disable-tv-v4l2
Comment 6 Esad Katmer 2019-09-14 18:08:54 UTC
Created attachment 589828 [details]
build-4-libv4l2.log

Error: waf: error: no such option: --disable-libv4l2
Comment 7 Esad Katmer 2019-09-14 18:09:15 UTC
Created attachment 589830 [details]
build-5-audio-input.log

Error: waf: error: no such option: --disable-audio-input
Comment 8 gerion 2019-09-25 12:29:17 UTC
Created attachment 591026 [details, diff]
quick-and-dirty.patch

Can confirm, there are also a lot more flags invalid. I have attached a quick and dirty patch so that it works with my configuration.
Comment 9 Ionen Wolkens gentoo-dev 2019-10-08 09:17:42 UTC
Can add --disable-zsh-comp to this issue which was also removed upstream 13 days ago.

On a side-note, mpv-0.29.0-make-ffmpeg-version-check-non-fatal.patch now also fails due added comments in the code (functionality appears unchanged).
Comment 10 Ionen Wolkens gentoo-dev 2019-10-13 08:14:07 UTC
To add to the side-note about the non-fatal patch, I believe it should be straight up removed due to this newer commit:
https://github.com/mpv-player/mpv/commit/a85fa2d2de92a89258da6b8bf6d814cf47824a0e
Comment 11 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2019-10-26 19:22:40 UTC
Should be in sync now.
Comment 12 Davide Palma 2019-10-26 21:01:00 UTC
Hi, there is a flag (and potentially others) that prevent
media-video/mpv-0.30.0::gentoo to be configured.
In my system, it's --enable-vaapi-glx that has the same behaviour of the others listed here.