Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 693316 - >=x11-libs/gtk+-3.24.10 is configured with hardcoded --disable-gtk-doc
Summary: >=x11-libs/gtk+-3.24.10 is configured with hardcoded --disable-gtk-doc
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-02 08:32 UTC by tt_1
Modified: 2019-09-02 11:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2019-09-02 08:32:27 UTC
--disable-gtk-doc is parsed by the gnome2.eclass: 

	# Preserve old behavior for older EAPI.
	if grep -q "enable-gtk-doc" "${ECONF_SOURCE:-.}"/configure ; then
		if has ${EAPI:-0} 4 && in_iuse doc ; then
			g2conf+=( $(use_enable doc gtk-doc) )
		else
			g2conf+=( --disable-gtk-doc )
		fi
	fi


but this is now controlled by the gtk-doc useflag, so the same argument can be parsed twice: 

--disable-gtk-doc --disable-maintainer-mode --disable-schemas-compile --disable-quartz-backend --disable-broadway-backend --disable-cloudprint --disable-colord --enable-cups=auto --disable-gtk-doc

or contradictory: 

--disable-gtk-doc --disable-maintainer-mode --disable-schemas-compile --disable-quartz-backend --disable-broadway-backend --disable-cloudprint --disable-colord --enable-cups=auto --enable-gtk-doc
Comment 1 Mart Raudsepp gentoo-dev 2019-09-02 08:35:14 UTC
Sure, all that is correct, but what is your problem with it?
Comment 2 tt_1 2019-09-02 08:48:08 UTC
So it's not a problem when one compile argement is parsed twice, or two contradictory ones are passed?
Comment 3 Mart Raudsepp gentoo-dev 2019-09-02 11:14:09 UTC
No, it's not a problem. With configure the last one of the same kind wins -- the --enable-gtk-doc will override the earlier --disable-gtk-doc from eclass.
Note that USE=gtk-doc on gtk+ merely regenerates the gtk-docs - you get them even without USE=gtk-doc. I added them because the pregenerated ones in tarballs lacked "Index of new symbols since 3.24" and co index sections, which I needed for my own work and thought them to be useful to be available for others that set global gtk-doc too (which is more used now with meson, as there you don't have any pregenerated docs installed without a USE flag)