Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 693144 - media-sound/audacity-2.3.2 - ?
Summary: media-sound/audacity-2.3.2 - ?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-08-30 19:29 UTC by David Carlos Manuelda
Modified: 2020-09-26 12:33 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix libtool linking (fix-libtool-link.patch,181 bytes, patch)
2019-08-30 19:30 UTC, David Carlos Manuelda
Details | Diff
Fix ill formed std::hash specialization (fix-ill-formed-std-hash-specialization.patch,349 bytes, patch)
2019-08-30 19:31 UTC, David Carlos Manuelda
Details | Diff
Disable experimental midi features if midi is disabled (fix-midi-disable-experimental.patch,475 bytes, patch)
2019-08-30 19:32 UTC, David Carlos Manuelda
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Carlos Manuelda 2019-08-30 19:29:46 UTC
Current audacity latest version (the one I tried) has compilation issues under certain conditions:

1: libtool fix
2: ill-formed std::hash specialization that does not compile if using libc++ instead of libstdc++
3: compilation with -midi will fail as of experimental feature about midi being defined regardless if midi was.

While this is reported by me to upstream (https://github.com/audacity/audacity/pull/374), I backported the changes to current latest 2.3.2 version to make it compile under Gentoo.
Comment 1 David Carlos Manuelda 2019-08-30 19:30:44 UTC
Created attachment 588550 [details, diff]
Fix libtool linking

Solved problem 1 about libtool not being able to link
Comment 2 David Carlos Manuelda 2019-08-30 19:31:32 UTC
Created attachment 588552 [details, diff]
Fix ill formed std::hash specialization

This addresses the compilation failure about std::hash specialization when using libc++ instead of libstdc++
Comment 3 David Carlos Manuelda 2019-08-30 19:32:09 UTC
Created attachment 588554 [details, diff]
Disable experimental midi features if midi is disabled

This address the problem of compile with midi IUSE disabled
Comment 4 Alexander Tsoy 2019-08-30 19:37:40 UTC
(In reply to David Carlos Manuelda from comment #0)
> 1: libtool fix
It is a bug 642758. And it shouldn't be fixed that way.

> 3: compilation with -midi will fail as of experimental feature about midi
> being defined regardless if midi was.
I think this was already worked around in ebuild?
Comment 5 David Carlos Manuelda 2019-08-30 19:56:54 UTC
(In reply to Alexander Tsoy from comment #4)
> (In reply to David Carlos Manuelda from comment #0)
> > 1: libtool fix
> It is a bug 642758. And it shouldn't be fixed that way.
Oh, I had this patch in /etc/portage/patches many time, did not see there was uploaded already
> 
> > 3: compilation with -midi will fail as of experimental feature about midi
> > being defined regardless if midi was.
> I think this was already worked around in ebuild?

It is not, at least not as of today, since I ran into this issue just today with synced tree.
Comment 6 David Carlos Manuelda 2019-08-30 20:08:50 UTC
> > > 3: compilation with -midi will fail as of experimental feature about midi
> > > being defined regardless if midi was.
> > I think this was already worked around in ebuild?
> 
> It is not, at least not as of today, since I ran into this issue just today
> with synced tree.

Sorry, seems you are right, now it compiles without midi flag, don't know why it did not compiled for me some hours ago
Comment 7 David Carlos Manuelda 2019-08-30 20:27:54 UTC
Update: patch3 only applies to upstream master, sorry for mixing things to this specific version.

Update2: pull request have been accepted and merged, hopefully we will not see those issues again in next releases ;)

I suggest to only pick my patch 2 for making this version compile with clang and/or libc++
Comment 8 mouac 2019-09-07 16:23:04 UTC
Even with these patches, I was still unable to compile the package.  It kept disabling my system portaudio because a function was missing.

What worked for me was the ebuild at https://data.gpo.zugaina.org/crocket-overlay/media-sound/audacity/.
Comment 9 Alexander Tsoy 2019-09-07 21:15:27 UTC
(In reply to mouac from comment #8)
It's a different issue. Please open new bug report.
Comment 10 Miroslav Šulc gentoo-dev 2020-09-19 11:39:39 UTC
please test with 2.4.2-r1 and report back
Comment 11 Miroslav Šulc gentoo-dev 2020-09-26 12:33:50 UTC
no reports, so closing.