Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 69213 - x11-libs/xosd supports bmp
Summary: x11-libs/xosd supports bmp
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Heinrich Wendel (RETIRED)
URL:
Whiteboard:
Keywords:
: 69449 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-27 21:57 UTC by Ray Tsang
Modified: 2005-07-25 03:36 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
x11-libs/xosd-2.2.12 (xosd-2.2.12.ebuild,991 bytes, text/plain)
2004-10-27 21:58 UTC, Ray Tsang
Details
xosd-2.2.12-r1.ebuild (Update - diff) (xosd-2.2.12-r1.diff,2.60 KB, text/plain)
2004-10-29 13:28 UTC, Joe Sapp (RETIRED)
Details
bmp-dlg_config.patch (bmp-dlg_config.patch,403 bytes, patch)
2004-10-29 13:32 UTC, Joe Sapp (RETIRED)
Details | Diff
Fixes for bmp (xosd-2.2.14-bmp-fixes.patch,11.20 KB, patch)
2005-03-28 11:42 UTC, Emil Beinroth
Details | Diff
New ebuild (uses patch and has updated DEPEND) (xosd-2.2.14.ebuild,1.16 KB, text/plain)
2005-03-28 11:46 UTC, Emil Beinroth
Details
Patch to current ebuild (xosd-2.2.14.ebuild) (xosd-2.2.14.ebuild.diff,1.44 KB, patch)
2005-04-17 14:24 UTC, Emil Beinroth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ray Tsang 2004-10-27 21:57:54 UTC
x11-lib/xosd-2.2.12 version bump,

it also seems to fix some hang/dealocks osd_cat from 2.2.10.


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Ray Tsang 2004-10-27 21:58:41 UTC
Created attachment 42745 [details]
x11-libs/xosd-2.2.12
Comment 2 Joe Sapp (RETIRED) gentoo-dev 2004-10-29 13:28:45 UTC
Created attachment 42877 [details]
xosd-2.2.12-r1.ebuild (Update - diff)

Attached is an update to the x11-libs/xosd-2.2.12 ebuild to make it compile
with support for the Beep Media Player
(http://www.sosdg.org/~larne/w/BMP_Homepage).  The 'bmp' USE flag was added to
make this an option for the user.  In order to do this, I had to make a
trivial, one-line patch for one file (attached), copy the files from the
xmms_plugin directory, and use sed to add and remove references depending on
the USE flags enabled (see comments in ebuild for more specifics).
Comment 3 Joe Sapp (RETIRED) gentoo-dev 2004-10-29 13:30:45 UTC
*** Bug 69449 has been marked as a duplicate of this bug. ***
Comment 4 Joe Sapp (RETIRED) gentoo-dev 2004-10-29 13:32:17 UTC
Created attachment 42878 [details, diff]
bmp-dlg_config.patch

Updates one line in src/bmp_plugin/dlg_config.c for GTK+-2
Comment 5 Heinrich Wendel (RETIRED) gentoo-dev 2004-11-06 07:09:42 UTC
thx, added the ebuild
Comment 6 CBke -Left- bye 2004-11-06 19:48:27 UTC
the BeepMediaPlayer-patch didn't work for me.
at runtime i get :

write(3, "(Gtk) invalid cast from `(unknown)\' to `(unknown)\'\n", 51) = 51
write(3, "(Gtk) file gtksignal.c: line 725 (gtk_signal_connect): assertion `GTK_IS_OBJECT (object)\' failed.\n", 98) = 98
write(3, "(Gtk) invalid cast from `(unknown)\' to `(unknown)\'\n", 51) = 51


when i want to open the configwindow

I tryed the same stradigy (as in the ebuild), but compiled against gtk-2.x, worked fine except for the font, the description changed quite a bit. (and i didn't find a solution since libxosd.so was compiled fo gtk 1.x)

the general way (according to bmp) is to try linking it up to gtk 2.x
but ` ldd /usr/lib/bmp/General/libbmp_osd.so` -> libgtk-1.2.so.0



Comment 7 CBke -Left- bye 2004-11-06 19:57:22 UTC
[the general way (according to bmp)]
http://www.sosdg.org/~larne/w/FAQ#Can_I_use_XMMS_plugins_with_BMP.3F
Comment 8 Heinrich Wendel (RETIRED) gentoo-dev 2004-11-07 03:19:45 UTC
will take another look at it
Comment 9 Joe Sapp (RETIRED) gentoo-dev 2004-11-08 05:30:11 UTC
From that same section:

Bear in mind that BMP uses GTK 2.4 while XMMS uses GTK 1.2. Consequently, XMMS plugins are compiled against 1.2 and will not work properly with BMP. The technical reason for this is that GTK 1.2 and GTK 2.4 share the same symbol names for the most part and there is no easy way to get the dynamic linker to the right ones. Any attempts to invoke a plugin's GUI controls (configuration dialog for example) will cause BMP to fail in the most unpleasant way.

I'm trying to see if I can fix this problem for you in the ebuild, but the original works on my system.
Comment 10 Heinrich Wendel (RETIRED) gentoo-dev 2005-02-19 12:05:59 UTC
maybe somebody can post an updated patch, i currently have no time to look at it
Comment 11 Heinrich Wendel (RETIRED) gentoo-dev 2005-03-25 03:46:57 UTC
ok, xosd-2.2.14 has bmp support
Comment 12 Emil Beinroth 2005-03-27 16:08:40 UTC
I think there is a small flaw in the patch: in xosd-2.2.14/src/bmp_plugin/bmp_osd.c "xmms/xmmsctrl.h" is included .. but that file is only present when xmms is installed. The right header to include would be "bmp/beepctrl.h".

I also noticed that the bmp_plugin does not require media-libs/gdk-pixbuf. BMP uses gtk+-2*.
Comment 13 Emil Beinroth 2005-03-28 11:42:37 UTC
Created attachment 54703 [details, diff]
Fixes for bmp

Fix includes for bmp and the configure.ac:
 * BMP (old and new) and XMMS (old) does not require gdk-pixbuf; XMMS (new)
does.
 * Fail when errors are detected rather than silently do what we can do. 
 * Make it possible to build BMP new/old and XMMS new/old independently.
Comment 14 Emil Beinroth 2005-03-28 11:46:24 UTC
Created attachment 54704 [details]
New ebuild (uses patch and has updated DEPEND)

This would be the proposed ebuild.
I removed the gdk-pixbuf dependency for +bmp and cleaned src_compile.
Comment 15 Heinrich Wendel (RETIRED) gentoo-dev 2005-03-29 10:22:48 UTC
reopen...
Comment 16 Heinrich Wendel (RETIRED) gentoo-dev 2005-04-13 11:05:33 UTC
please post only patches
Comment 17 Emil Beinroth 2005-04-17 14:24:47 UTC
Created attachment 56542 [details, diff]
Patch to current ebuild (xosd-2.2.14.ebuild)

As you command
Comment 18 Emil Beinroth 2005-04-17 14:41:04 UTC
And I'am sorry, but this should not be marked as enhancement .. it's a "normal" bug.
You can't build the bmp-plugin without having xmms installed and in USE.
Comment 19 Emil Beinroth 2005-04-18 14:59:20 UTC
I didn't mean to sound impatient and rude. Sorry for that.
Comment 20 Heinrich Wendel (RETIRED) gentoo-dev 2005-05-16 04:11:58 UTC
sorry for the delay, thx for the patches, fixed
Comment 21 MAL 2005-07-25 03:36:13 UTC
This is resolved fixed, but the plugin really doesn't work.  The preferences 
dialog is nonsense.  How are you meant to configure this plugin?