Bug 692050 – sys-libs/metrics-discovery - a user mode library that provides access to GPU performance data

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description Ankit Navik 2019-08-13 08:19:13 UTC]

Created attachment 586704 [details]
metrics-discovery-1.5.108.ebuild

Hi!

Please find attached metrics-discovery-1.5.108.ebuild

Metrics Discovery is a user mode library that provides access to GPU performance data. The library has OS abstraction layer that allows for interoperability in different environments.

I suggest media-libs/metrics-discovery. 

ankit

[Comment 1 Jeroen Roovers (RETIRED) 2019-08-16 11:26:48 UTC]

Comment on attachment 586704 [details]
metrics-discovery-1.5.108.ebuild

># Distributed under the terms of the GNU General Public License v2
>
>EAPI=4

I do not see a reason not to use the latest EAPI.

>inherit cmake-utils
>
>DESCRIPTION="Intel Metrics Discovery Application Programming Interface"

This description does not match the website's description.

>HOMEPAGE="https://github.com/intel/metrics-discovery"
>SRC_URI="https://github.com/intel/metrics-discovery/archive/${P}.tar.gz"
>
>LICENSE="MIT"
>SLOT="0"
>KEYWORDS="*"
>IUSE=""
>
>src_configure() {
>	local mycmakeargs=(
>		.
>	)

What does the dot do?

>
>	cmake-utils_src_configure
>}
>
>src_install() {
>	default
>}

src_install() is defined by default, so you shouldn't need to explicate this.

[Comment 2 Ankit Navik 2019-08-20 03:16:28 UTC]

(In reply to Jeroen Roovers from comment #1)
> Comment on attachment 586704 [details]
> metrics-discovery-1.5.108.ebuild
> 
> ># Distributed under the terms of the GNU General Public License v2
> >
> >EAPI=4
> 
> I do not see a reason not to use the latest EAPI.

Ok, I will use the latest EAPI. 
> 
> >inherit cmake-utils
> >
> >DESCRIPTION="Intel Metrics Discovery Application Programming Interface"
> 
> This description does not match the website's description.

github doesn't have any description. Shall I use "Intel Metrics Discovery Application Programming Interface is a user mode library that provides access to GPU performance data."?
> 
> >HOMEPAGE="https://github.com/intel/metrics-discovery"
> >SRC_URI="https://github.com/intel/metrics-discovery/archive/${P}.tar.gz"
> >
> >LICENSE="MIT"
> >SLOT="0"
> >KEYWORDS="*"
> >IUSE=""
> >
> >src_configure() {
> >	local mycmakeargs=(
> >		.
> >	)
> 
> What does the dot do?

My bad, I referred github and kept for cmake generation.
I will remove it. 
> 
> >
> >	cmake-utils_src_configure
> >}
> >
> >src_install() {
> >	default
> >}
> 
> src_install() is defined by default, so you shouldn't need to explicate this.

I was not aware of it. Thank you for your valuable feedback.

[Comment 3 Ankit Navik 2019-08-20 03:22:33 UTC]

Created attachment 587592 [details, diff]
metrics-discovery-1.5.108.ebuild

[Comment 4 Ankit Navik 2019-09-10 03:27:28 UTC]

Can you please review ?

[Comment 5 Ankit Navik 2019-09-27 03:06:52 UTC]

Let me know any feedback on the patch.

[Comment 6 Ankit Navik 2019-11-21 05:04:15 UTC]

When can I expect this changes to be merged ?

[Comment 7 sylvain.miossec 2020-06-05 12:16:03 UTC]

I tried your ebuild.
Not sure it is the proper way but I had to add 
S=${WORKDIR}/${PN}-${P}
because the unpacking directory was different than expected