Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 690524 - folks-0.13.1-r1.ebuild (Updated package)
Summary: folks-0.13.1-r1.ebuild (Updated package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-23 19:56 UTC by Christina Vitting
Modified: 2021-03-15 01:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-libs/folks-0.13.1-r1 (Updated package) (folks-0.13.1-r1.ebuild,1.94 KB, text/plain)
2019-07-23 19:56 UTC, Christina Vitting
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christina Vitting 2019-07-23 19:56:17 UTC
Created attachment 584246 [details]
dev-libs/folks-0.13.1-r1 (Updated package)

Hi!

Please find attached folks-0.13.1-r1.ebuild. Uses Meson in lieu of gnome2 configure.

Tina
Comment 1 Christina Vitting 2019-07-23 19:59:02 UTC
Comment on attachment 584246 [details]
dev-libs/folks-0.13.1-r1 (Updated package)

># Copyright 1999-2019 Gentoo Authors
># Distributed under the terms of the GNU General Public License v2
>
>EAPI=6
>GNOME2_LA_PUNT="yes"
>VALA_USE_DEPEND="vapigen"
>
>inherit gnome2 meson vala virtualx
>
>DESCRIPTION="Library for aggregating people from multiple sources"
>HOMEPAGE="https://wiki.gnome.org/Projects/Folks"
>
>LICENSE="LGPL-2.1+"
>SLOT="0/25" # subslot = libfolks soname version
>KEYWORDS="~alpha amd64 ~arm ~ia64 ~ppc ~ppc64 ~sparc x86 ~x86-linux"
>
># TODO: --enable-profiling
># Vala isn't really optional, https://bugzilla.gnome.org/show_bug.cgi?id=701099
>IUSE="bluetooth debug eds +telepathy test tracker utils"
>REQUIRED_USE="bluetooth? ( eds )"
>
>COMMON_DEPEND="
>	$(vala_depend)
>	>=dev-libs/glib-2.40:2
>	dev-libs/dbus-glib
>	>=dev-libs/gobject-introspection-1.30:=
>	>=dev-libs/libgee-0.10:0.8[introspection]
>	dev-libs/libxml2
>	sys-libs/ncurses:0=
>	sys-libs/readline:0=
>
>	bluetooth? ( >=net-wireless/bluez-5 )
>	eds? ( >=gnome-extra/evolution-data-server-3.13.90:=[vala] )
>	telepathy? ( >=net-libs/telepathy-glib-0.19.9[vala] )
>	tracker? ( >=app-misc/tracker-1:0= )
>"
># telepathy-mission-control needed at runtime; it is used by the telepathy
># backend via telepathy-glib's AccountManager binding.
>RDEPEND="${COMMON_DEPEND}
>	net-im/telepathy-mission-control
>"
># folks socialweb backend requires that libsocialweb be built with USE=vala,
># even when building folks with --disable-vala.
>#
># FIXME:
># test? ( bluetooth? ( dbusmock is missing in the tree ) )
>DEPEND="${COMMON_DEPEND}
>	>=dev-util/intltool-0.50.0
>	sys-devel/gettext
>	virtual/pkgconfig
>
>	test? (
>		sys-apps/dbus
>		bluetooth? (
>			>=gnome-extra/evolution-data-server-3.9.1
>			>=dev-libs/glib-2.40:2 ) )
>"
>
>src_prepare() {
>	# Force re-generation of introspection files, otherwise it does not match installed libs
>	find -name "*.vala" -exec touch {} \; || die
>
>	vala_src_prepare
>	gnome2_src_prepare
>	meson_src_prepare
>}
>
>src_test() {
>	dbus-launch virtx emake check
>}
Comment 2 Mart Raudsepp gentoo-dev 2019-07-23 20:07:44 UTC
0.13.1 is a development cycle release, that requires >=evolution-data-server-3.33.2 with USE=eds (which you have not updated accordingly in your ebuild), so we won't be adding that anytime soon.
0.12.1 is another matter though, and was on my lower priority TODO list. You could take a stab at that, if you want.

Don't use gnome2.eclass with meson at all, get SRC_URI from gnome.org and most of the boilerplate from xdg.eclass, with gnome2-utils manual calls if need be for any glib schemas or other stuff. vala files touching probably makes no sense either anymore, as meson doesn't pregenerate them, so it'll be all built anyways. src_test of yours can't work with meson. I suggest taking a peek at some other meson using gnome package, perhaps one that uses vala too (tracker comes to my mind immediately, but that's complex, there are many others by now that are better examples).
intltool is unlikely to be still necessary with a meson port (but there are very few exceptions where a meson.build file actually calls intltool-merge or something).

Basically this needs a lot of work, and 0.12.1 instead then please. This is especially useful if you want to learn or help with other stuff in the long term as well.
Comment 3 Christina Vitting 2019-07-23 20:44:40 UTC
Thank you for your help. Would you be so kind as to put me in touch with someone who can look over my timeshift ebuild? I have a Bugzilla submission for it.
Comment 4 Mart Raudsepp gentoo-dev 2019-07-24 05:31:31 UTC
You could maybe formulate it as a pull request on github too, with a backlink to the bugzilla one, and also make yourself the (proxied) maintainer of it and submit the PR with that. Then the proxy maintainers team will look over it, but you'd have to maintain it yourself afterwards with their help (you being marked as the maintainer, receiving bug reports, etc). Look up gentoo proxy maintainers wiki pages.
Comment 5 Mart Raudsepp gentoo-dev 2019-07-24 06:05:24 UTC
I believe you mentioned elsewhere, that the main tree folks doesn't compile anymore, presumably with some newer stuff of something else from some overlay. Can you please elaborate on that, so we can be prepared for the main tree accordingly?
Comment 6 Christina Vitting 2019-07-24 13:31:49 UTC
I created a pull request for Timeshift on github, and referenced the bugzilla one. Thanks for the suggestion.

Of the main tree folks, I downgraded to dev-libs/glib-2.58.3-r1, dev-libs/gobject-introspection-1.58.3, dev-libs/gobject-introspection-common-1.58.3, dev-util/glib-utils-2.58.3, net-libs/glib-networking-2.58.0, dev-libs/json-glib-1.4.4::gentoo, dev-lang/vala-0.42.7, dev-libs/vala-common-0.42.7, gnome-extra/evolution-data-server-3.30.5-r1, dev-util/gdbus-codegen-2.58.3, and net-libs/telepathy-glib-0.24.1. That seemed to fix the issue. That said, I was able to get folks-0.13.1-r1 added to the gnome-next overlay, so it's improbable going forward that newer stuff will prevent folks from being installed.

https://github.com/Heather/gentoo-gnome/commit/57a2b884d6033c967678773459301d6171d7d698

Thank you for your help by the way :)
Comment 7 Matt Turner gentoo-dev 2021-03-15 01:47:40 UTC
folks-0.14.0 has been in tree and stable since Aug 2020.