69020 – The for loop in function userquery() (file /bin/emerge line 85) is duplicated

Bug 69020 - The for loop in function userquery() (file /bin/emerge line 85) is duplicated

Summary: The for loop in function userquery() (file /bin/emerge line 85) is duplicated

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core (show other bugs)
Hardware:	All All

Importance:	Lowest trivial (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:	InVCS

Duplicates (1):	69023 (view as bug list)
Depends on:
Blocks:

Reported:	2004-10-26 07:37 UTC by Martin Cavaillès
Modified:	2004-11-01 00:01 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Martin Cavaillès 2004-10-26 07:38:09 UTC

Hi,

first i'm really sorry if this is not a bug, I'm not at all a professional Python programmer (just a beginner :) ) and so I might have not seen a good or at least practical reason for this duplicate...

So here it is : while browsing Portage code, I noticed that in function userquery(), file /bin/emerge (around line 85), the following for loop : 

for key in responses:
	if response.upper()==key[:len(response)].upper():
		return key

was duplicated; so it's not a major problem, I know, but is it necessary? Again, sorry if I made a mistake, I just wanted to share it and help

Oh yes I checked in CVS too and the for loop is still there twice

Thanks

Comment 1 Martin Cavaillès 2004-10-26 08:16:37 UTC

*** Bug 69023 has been marked as a duplicate of this bug. ***

Comment 2 Martin Cavaillès 2004-11-01 00:01:29 UTC

This bug has been fixed in CVS by jstubb :)

Thanks