Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 690148 - dev-ruby/did_you_mean-1.2.1: tests VerboseFormatterTest NameErrorExtensionTest are failing
Summary: dev-ruby/did_you_mean-1.2.1: tests VerboseFormatterTest NameErrorExtensionTes...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2019-07-18 14:20 UTC by Thomas Deutschmann (RETIRED)
Modified: 2019-09-03 07:50 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,4.94 KB, text/plain)
2019-07-18 14:20 UTC, Thomas Deutschmann (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann (RETIRED) gentoo-dev 2019-07-18 14:20:04 UTC
Created attachment 583390 [details]
build.log

>>> Test phase: dev-ruby/did_you_mean-1.2.1
 * Running test phase for ruby25 ...
/usr/bin/ruby25 -w -I"lib:test" -I"/usr/lib/ruby/gems/2.5.0/gems/rake-12.3.1/lib" "/usr/lib/ruby/gems/2.5.0/gems/rake-12.3.1/lib/rake/rake_test_loader.rb" "test/core_ext/name_error_extension_test.rb" "test/edit_distance/jaro_winkler_test.rb" "test/verbose_formatter_test.rb" "test/spell_checker_test.rb" "test/deprecated_formatter_test.rb" "test/spell_checking/uncorrectable_name_check_test.rb" "test/spell_checking/key_name_check_test.rb" "test/spell_checking/class_name_check_test.rb" "test/spell_checking/variable_name_check_test.rb" "test/spell_checking/method_name_check_test.rb" 
DidYouMean version: 1.2.1
/var/tmp/portage/dev-ruby/did_you_mean-1.2.1/work/ruby25/did_you_mean-1.2.1/test/spell_checking/variable_name_check_test.rb:61: warning: assigned but unused variable - some_var
Run options: --seed 56135

# Running:

..........F...............................F

Fabulous run in 0.091573s, 469.5701 runs/s, 1900.1207 assertions/s.

  1) Failure:
VerboseFormatterTest#test_message [/var/tmp/portage/dev-ruby/did_you_mean-1.2.1/work/ruby25/did_you_mean-1.2.1/test/verbose_formatter_test.rb:16]:
--- expected
+++ actual
@@ -1,4 +1,5 @@
-"undefined local variable or method `doesnt_exist' for VerboseFormatterTest#test_message
+# encoding: US-ASCII
+"undefined local variable or method `doesnt_exist' for #<VerboseFormatterTest:0xXXXXXX>
 
     Did you mean? does_exist
  "


  2) Failure:
NameErrorExtensionTest#test_message [/var/tmp/portage/dev-ruby/did_you_mean-1.2.1/work/ruby25/did_you_mean-1.2.1/test/core_ext/name_error_extension_test.rb:27]:
--- expected
+++ actual
@@ -1,2 +1,3 @@
-"undefined local variable or method `doesnt_exist' for NameErrorExtensionTest#test_message
+# encoding: US-ASCII
+"undefined local variable or method `doesnt_exist' for #<NameErrorExtensionTest:0xXXXXXX>
 Did you mean?  does_exist"


43 runs, 174 assertions, 2 failures, 0 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -w -I"lib:test" -I"/usr/lib/ruby/gems/2.5.0/gems/rake-12.3.1/lib" "/usr/lib/ruby/gems/2.5.0/gems/rake-12.3.1/lib/rake/rake_test_loader.rb" "test/core_ext/name_error_extension_test.rb" "test/edit_distance/jaro_winkler_test.rb" "test/verbose_formatter_test.rb" "test/spell_checker_test.rb" "test/deprecated_formatter_test.rb" "test/spell_checking/uncorrectable_name_check_test.rb" "test/spell_checking/key_name_check_test.rb" "test/spell_checking/class_name_check_test.rb" "test/spell_checking/variable_name_check_test.rb" "test/spell_checking/method_name_check_test.rb" ]
Comment 1 Hans de Graaff gentoo-dev Security 2019-07-19 05:18:11 UTC
I can't reproduce this. Are you perhaps running these tests on a system without any utf8 locale?
Comment 2 Rolf Eike Beer archtester 2019-07-23 20:26:27 UTC
I have the same on hppa, and all locales installed.
Comment 3 Hans de Graaff gentoo-dev Security 2019-07-25 06:05:34 UTC
I've removed the blocker because this issue should not hold up stabling of ruby25. Everything here is working as intended but the tests don't expect this encoding issue.

That said I'd like to understand better what is going on. Could people who have this issue include the output of `locale` and `locale -a` of the shell that the tests are run in?
Comment 4 Alexey 2019-09-03 07:49:58 UTC
Here's in my usual shell:

$ locale
LANG=ru_RU.utf8
LC_CTYPE="ru_RU.utf8"
LC_NUMERIC="ru_RU.utf8"
LC_TIME="ru_RU.utf8"
LC_COLLATE="ru_RU.utf8"
LC_MONETARY="ru_RU.utf8"
LC_MESSAGES="ru_RU.utf8"
LC_PAPER="ru_RU.utf8"
LC_NAME="ru_RU.utf8"
LC_ADDRESS="ru_RU.utf8"
LC_TELEPHONE="ru_RU.utf8"
LC_MEASUREMENT="ru_RU.utf8"
LC_IDENTIFICATION="ru_RU.utf8"
LC_ALL=

$ locale -a
C
C.utf8
en_US.utf8
POSIX
ru_RU.utf8

Where to find the shell that the tests are run in?