Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 689318 - media-gfx/luminance-hdr-2.5.1-r1[openmp] fails to build with gcc 9: display_adaptive_tmo.cpp:454:3: error: 'pix_count' not specified in enclosing 'parallel'
Summary: media-gfx/luminance-hdr-2.5.1-r1[openmp] fails to build with gcc 9: display_a...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard: openmp
Keywords: Bug
Depends on: 688718
Blocks:
  Show dependency tree
 
Reported: 2019-07-05 10:56 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2019-10-27 09:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2019-07-05 10:56:19 UTC
This *could* be GCC update related, or boost related (found this while recompiling for boost upgrade for boost 0/1.70.0, but hasn't been recompiled since I upgraded GCC to 9.1.0)

But I note, that upstream on the 2.6.0 release commit series, there is a commit labelled "fix compilation with gcc9", who's context looks intruigingly related:

https://github.com/LuminanceHDR/LuminanceHDR/commit/07592748a52701a3ce41a376efe6ec3797cc3e0d#diff-77302c2c287d0993396ad79a229ac8b0

So theoretically, shipping the 2.6.0 bump may fix this, or backporting the fix may also.


[ 21%] Building CXX object src/MainWindow/CMakeFiles/mainwindow.dir/UpdateChecker.cpp.o
cd /var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1_build/src/MainWindow && /usr/bin/x86_64-pc-linux-gnu-g++ -DBRANCH_PREDICTION -DHAVE_FFTW3F -DLHDR_CXX11_ENABLED -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_XML_LIB -I/usr/include/libraw -I/usr/include/exiv2 -I/usr/include/OpenEXR -I/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src -I/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1_build/src -I/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1_build -I/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1_build/src/MainWindow -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtConcurrent   -DNDEBUG -O2 -pipe -mtune=native -march=native -fopenmp   -Wall -Wno-unknown-pragmas -ffast-math -fPIC -std=gnu++11 -o CMakeFiles/mainwindow.dir/UpdateChecker.cpp.o -c /var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/MainWindow/UpdateChecker.cpp
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp: In function ‘std::unique_ptr<datmoConditionalDensity> datmo_compute_conditional_density(int, int, const float*, pfs::Progress&)’:
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:454:3: error: ‘pix_count’ not specified in enclosing ‘parallel’
  454 |   for( int i=0; i < pix_count; i++ )
      |   ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:452:9: error: enclosing ‘parallel’
  452 | #pragma omp parallel for default(none) shared(LP_high_raw, L)
      |         ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:455:32: error: ‘min_va ’ not specified in enclosing ‘parallel’
  455 |     LP_high_raw[i] = safe_log10( L[i], min_val );
      |                      ~~~~~~~~~~^~~~~~~~~~~~~~~~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:452:9: error: enclosing ‘parallel’
  452 | #pragma omp parallel for default(none) shared(LP_high_raw, L)
      |         ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp: In function ‘void compute_gaussian_level(int, int, const Array2Df&, pfs::Array2Df&, int, pfs::Array2Df&)’:
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:312:3: error: ‘height’ not specified in enclosing ‘parallel’
  312 |   for( int r=0; r < height; r++ ) {
      |   ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:311:9: error: enclosing ‘parallel’
  311 | #pragma omp parallel for default(none) shared(in_raw, temp_raw, kernel)
      |         ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:313:23: error: ‘width’ not specified in enclosing ‘parallel’
  313 |     for( int c=0; c < width; c++ ) {
      |                       ^~~~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:311:9: error: enclosing ‘parallel’
  311 | #pragma omp parallel for default(none) shared(in_raw, temp_raw, kernel)
      |         ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:316:34: error: ‘step’ not specified in enclosing ‘parallel’
  316 |         int l = (j-kernel_len_2)*step+c;
      |                                  ^~~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:311:9: error: enclosing ‘parallel’
  311 | #pragma omp parallel for default(none) shared(in_raw, temp_raw, kernel)
      |         ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:329:3: error: ‘width’ not specified in enclosing ‘parallel’
  329 |   for( int c=0; c < width; c++ ) {
      |   ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:328:9: error: enclosing ‘parallel’
  328 | #pragma omp parallel for default(none) shared(temp_raw, out_raw, kernel)
      |         ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:330:23: error: ‘height’ not specified in enclosing ‘parallel’
  330 |     for( int r=0; r < height; r++ ) {
      |                       ^~~~~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:328:9: error: enclosing ‘parallel’
  328 | #pragma omp parallel for default(none) shared(temp_raw, out_raw, kernel)
      |         ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:333:34: error: ‘step’ not specified in enclosing ‘parallel’
  333 |         int l = (j-kernel_len_2)*step+r;
      |                                  ^~~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:328:9: error: enclosing ‘parallel’
  328 | #pragma omp parallel for default(none) shared(temp_raw, out_raw, kernel)
      |         ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp: In function ‘int datmo_apply_tone_curve_cc(float*, float*, float*, int, int, const float*, const float*, const float*, const float*, datmoToneCurve*, DisplayFunction*, float)’:
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:1081:3: error: ‘pix_count’ not specified in enclosing ‘parallel’
 1081 |   for (long i=0; i < pix_count; i++)
      |   ^~~
/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1/src/TonemappingOperators/mantiuk08/display_adaptive_tmo.cpp:1080:9: error: enclosing ‘parallel’
 1080 | #pragma omp parallel for default(none) shared(R_in,G_in,B_in,L_in,R_out,G_out,B_out,tc_lut,cc_lut,df)
      |         ^~~
make[2]: *** [src/TonemappingOperators/CMakeFiles/pfstmo.dir/build.make:349: src/TonemappingOperators/CMakeFiles/pfstmo.dir/mantiuk08/display_adaptive_tmo.cpp.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/media-gfx/luminance-hdr-2.5.1-r1/work/luminance-hdr-2.5.1_build'
make[1]: *** [CMakeFiles/Makefile2:603: src/TonemappingOperators/CMakeFiles/pfstmo.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....


 emerge --info media-gfx/luminance-hdr
Portage 2.3.66 (python 3.7.3-final-0, default/linux/amd64/17.0, gcc-9.1.0, glibc-2.29-r2, 5.0.2-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.0.2-gentoo-x86_64-Intel-R-_Core-TM-_i5-2410M_CPU_@_2.30GHz-with-gentoo-2.6
KiB Mem:     8004712 total,   2650516 free
KiB Swap:   20478972 total,  20478192 free
Timestamp of repository gentoo: Wed, 03 Jul 2019 21:00:01 +0000
Head commit of repository gentoo: 67db2ad3482a8bfe3445ecf9c2fef8e9869f6982
sh bash 5.0_p7
ld GNU ld (Gentoo 2.32 p2) 2.32.0
ccache version 3.7.1 [disabled]
app-shells/bash:          5.0_p7::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.30.0::gentoo
dev-lang/python:          2.7.16::gentoo, 3.6.8::gentoo, 3.7.3::gentoo
dev-util/ccache:          3.7.1::gentoo
dev-util/cmake:           3.14.5::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.41.2::gentoo
sys-apps/sandbox:         2.17::gentoo
sys-devel/autoconf:       2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.32-r1::gentoo
sys-devel/gcc:            6.4.0-r5::gentoo, 9.1.0-r1::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.0-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.29-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage/
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: --delete-delay --fuzzy --temp-dir=/var/tmp/rsync/

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -mtune=native -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.3/ext-active/ /etc/php/cgi-php7.3/ext-active/ /etc/php/cli-php7.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -mtune=native -march=native"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--alert y --changed-deps y --changed-use --complete-graph=n --with-bdeps=n --deep --dynamic-deps n --keep-going y --newuse --verbose-conflicts --unordered-display --autounmask n --backtrack=0 --autounmask-write n"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup clean-logs compress-build-logs compressdebug config-protect-if-modified distlocks fixlafiles ipc-sandbox merge-sync metadata-transfer multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned sandbox sfperms sign split-elog split-log splitdebug strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ember./ http://distfiles.gentoo.org/ "
INSTALL_MASK="/usr/lib/debug/.build-id/"
LANG="en_NZ.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS=" -j3 --load-average=4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--delete-delay --fuzzy --temp-dir=/var/tmp/rsync/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
Unset:  CC, CPPFLAGS, CTARGET, CXX, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS

=================================================================
                        Package Settings
=================================================================

media-gfx/luminance-hdr-2.5.1-r1::gentoo was built with the following:
USE="openmp -fits -test" ABI_X86="(64)" CPU_FLAGS_X86="sse2" L10N="-cs -de -es -fi -fr -hi -hu -id -it -pl -ro -ru -sk -tr -zh"
Comment 1 Michael 'veremitz' Everitt 2019-07-05 11:52:50 UTC
Yeah there's several of this 'type' of bug I'm seeing in the gcc-9 tracker, all seem to be relating to the openmp within gcc9. Tagging as such in the whiteboard.
Comment 2 Andreas Sturmlechner gentoo-dev 2019-09-15 22:26:17 UTC
Fixed by 2.6.0 in git commit 09e8558542be24aba424ef8427ab45f818ea8fac.